You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by NOMORECOFFEE <gi...@git.apache.org> on 2015/04/07 13:09:41 UTC
[GitHub] thrift pull request: THRIFT-3087 Pass on errors like "connection c...
GitHub user NOMORECOFFEE opened a pull request:
https://github.com/apache/thrift/pull/430
THRIFT-3087 Pass on errors like "connection closed"
Currently client received 'badmatch' error when the thrift server teardown. I'd like information about errors in the thrift clinet before the process exits.
I've attached an implementation which fixes this good enough for my own and add test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NOMORECOFFEE/thrift handle_errors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/430.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #430
----
commit 17d416aca5c5037ff233d4c2e7afa0ea36df5f06
Author: NOMORECOFFEE <gi...@hotmail.com>
Date: 2015-04-06T10:55:08Z
thrift_reconnecting_client never try to reconnect
gen_server does not handle message try_connect after unsuccessful connection, and gen_server always return {error, noconn}
THRIFT-3085
commit 34a5ac80cacdc215f649865290a052575e3a2e43
Author: Веселов <ve...@corp.sputnik.ru>
Date: 2015-04-07T08:29:59Z
catch badmatch to pass errors into handler module
commit fcb89172b4c63bca020bb6953537ef3d7259ad48
Author: Веселов <ve...@corp.sputnik.ru>
Date: 2015-04-07T10:22:26Z
test handle transport error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3087 Pass on errors like "connection c...
Posted by NOMORECOFFEE <gi...@git.apache.org>.
Github user NOMORECOFFEE closed the pull request at:
https://github.com/apache/thrift/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---