You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/14 20:56:18 UTC

[GitHub] [helix] qqu0127 commented on pull request #2035: MaintenanceManagementService improvement - Allow implementation of OperationInterface to return null

qqu0127 commented on PR #2035:
URL: https://github.com/apache/helix/pull/2035#issuecomment-1099614107

   The impl looks good with minor comments, but here are some general questions on the design.
   Could you share more context on why the service silently fail? 
   Also I'm wondering if a null value makes sense in the first place. Will something like a default or empty value be better?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org