[GitHub] spark pull request #13868: [SPARK-15899] [SQL] Fix the construction of the f...

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13868#discussion_r69639163
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with CatalystConf with Logging {
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
       def warehousePath: String = {
    -    getConf(WAREHOUSE_PATH).replace("${system:user.dir}", System.getProperty("user.dir"))
    +    new Path(getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
    +      System.getProperty("user.dir"))).toUri.toString
    --- End diff --
    
    As `warehousePath` will be used like `new Path(warehousePath)`, this will introduce a regression when the path contains spaces or other special characters. E.g.,
    
    ```
    scala> new Path("foo bar")
    res4: org.apache.hadoop.fs.Path = foo bar
    
    scala> new Path(new Path("foo bar").toUri.toString)
    res5: org.apache.hadoop.fs.Path = foo%20bar
    ```
    
    @avulanov could you try the following code in Windows and see if it works?
    ```
    new Path(new Path(getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
           System.getProperty("user.dir"))).toUri).toString
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org