You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/25 17:04:20 UTC

[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #622: [SCB-1685] Change Assert method contains to hasItems

coolbeevip opened a new pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622
 
 
   Because the table scan mode cannot guarantee the order of asynchronous compensation messages, test case doNotCompensateDuplicateTxOnFailure will occasionally fail on CI
   
   ```bash
   Failed tests: 
     AlphaIntegrationTest.doNotCompensateDuplicateTxOnFailure:289 
   Expected: iterable containing [<globalTxId: "b402c45a-ef25-4061-a5d7-a25eff120c3d"
   localTxId: "1f438adb-6b62-41f6-bcc6-e11c791b918f"
   parentTxId: "70f07983-0aa6-4fc2-99b0-545b43e7c214"
   compensationMethod: "method b"
   payloads: "service b"
   >, <globalTxId: "b402c45a-ef25-4061-a5d7-a25eff120c3d"
   localTxId: "a4eafa18-fcdf-4363-b5dd-a9e647096e15"
   parentTxId: "bb87ca5b-1fc8-45fe-931e-67eb8e13405f"
   compensationMethod: "method a"
   payloads: "service a"
   >]
        but: item 0: was <globalTxId: "b402c45a-ef25-4061-a5d7-a25eff120c3d"
   localTxId: "a4eafa18-fcdf-4363-b5dd-a9e647096e15"
   parentTxId: "bb87ca5b-1fc8-45fe-931e-67eb8e13405f"
   compensationMethod: "method a"
   payloads: "service a"
   >
   Tests run: 104, Failures: 1, Errors: 0, Skipped: 0
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] WillemJiang merged pull request #622: [SCB-1685] Change Assert method contains to containsInAnyOrder

Posted by GitBox <gi...@apache.org>.
WillemJiang merged pull request #622: [SCB-1685] Change Assert method contains to containsInAnyOrder
URL: https://github.com/apache/servicecomb-pack/pull/622
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361572746
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   Ok, I will try to use containsInAnyOrder instead of contains

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361475391
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   L287 passed, Fails on L289

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to containsInAnyOrder

Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #622: [SCB-1685] Change Assert method contains to containsInAnyOrder
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361582809
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls edited a comment on issue #622: [SCB-1685] Change Assert method contains to containsInAnyOrder

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #622: [SCB-1685] Change Assert method contains to containsInAnyOrder
URL: https://github.com/apache/servicecomb-pack/pull/622#issuecomment-568918344
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27808004/badge)](https://coveralls.io/builds/27808004)
   
   Coverage decreased (-0.04%) to 80.026% when pulling **799c7ede5991330e2aa80efc70d4b921043a796d on coolbeevip:SCB-1685** into **41504a11c51deb34a6c2c60e80ac5669b92bc695 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361571988
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   hasItems cannot assert we got all the event we wants.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361558298
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   await() just wait for the condition is true or the timeout.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#discussion_r361414813
 
 

 ##########
 File path: alpha/alpha-server/src/test/java/org/apache/servicecomb/pack/alpha/server/AlphaIntegrationTest.java
 ##########
 @@ -286,7 +286,7 @@ public void doNotCompensateDuplicateTxOnFailure() {
     blockingStub.onTxEvent(someGrpcEvent(TxAbortedEvent));
     await().atMost(1, SECONDS).until(() -> receivedCommandsCounter.get() > 1);
 
 Review comment:
   The test failure is caused by the receivedCommandCounter is less than 2. 
   I think we should wait for a bit more time for it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-pack] coveralls commented on issue #622: [SCB-1685] Change Assert method contains to hasItems

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #622: [SCB-1685] Change Assert method contains to hasItems
URL: https://github.com/apache/servicecomb-pack/pull/622#issuecomment-568918344
 
 
   
   [![Coverage Status](https://coveralls.io/builds/27791394/badge)](https://coveralls.io/builds/27791394)
   
   Coverage decreased (-0.02%) to 80.048% when pulling **c143304d66f7603805a95e45dcbde0fef224c6be on coolbeevip:SCB-1685** into **41504a11c51deb34a6c2c60e80ac5669b92bc695 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services