[jira] [Commented] (HBASE-15945) Patch for Key Value, Bytes and Cell

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312504#comment-15312504 ] 

stack commented on HBASE-15945:
-------------------------------

[~sudeeps] I think @enis says this elsewhere, but no need to emulate what is in java. In fact, don't. Java is in a state of transition trying to move off the KeyValue type instead to run on a Cell Interface. The KV type will change. This code as is doesn't allow for that. Tags do not make it out on to the Client-side FYI. That KV public interface is really broad. You want to open up that much API? Some tests for the public API should come in w/ this patch too? You have any?

Feedback on the patch....

Suggest you use the new ./dev-support/submit-patch.py It will make a patch, update the JIRA and ReviewBoard all from command-line.

It looks like a pure copy of the java Bytes class (is that compare method correct? It just compares instances... should it not compare byte content too... unless the operator is overloaded?)

Should there be sequenceid in Cell?

Thanks.






> Patch for Key Value, Bytes and Cell
> -----------------------------------
>
>                 Key: HBASE-15945
>                 URL: https://issues.apache.org/jira/browse/HBASE-15945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>         Attachments: HBASE-15945.HBASE-14850.v1.patch
>
>
> This patch contains an implementation of Key Value, Bytes and Cell modeled on the lines of Java implementation.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)