You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/05 22:30:35 UTC
Review Request 35150: Add output stream operation for handle to use in
port_mapping.cpp
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35150/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Add output stream operation for handle to use in port_mapping.cpp
Diffs
-----
src/linux/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10
Diff: https://reviews.apache.org/r/35150/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35150: Add output stream operation for handle to
use in port_mapping.cpp
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35150/#review86845
-----------------------------------------------------------
Ship it!
Ship It!
- Chi Zhang
On June 5, 2015, 8:30 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35150/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:30 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add output stream operation for handle to use in port_mapping.cpp
>
>
> Diffs
> -----
>
> src/linux/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10
>
> Diff: https://reviews.apache.org/r/35150/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 35150: Add output stream operation for handle to
use in port_mapping.cpp
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35150/
-----------------------------------------------------------
(Updated June 5, 2015, 11:33 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Changes
-------
Incorporated reviewer feedback.
Bugs: MESOS-2821
https://issues.apache.org/jira/browse/MESOS-2821
Repository: mesos
Description
-------
Add output stream operation for handle to use in port_mapping.cpp
Diffs (updated)
-----
src/linux/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10
Diff: https://reviews.apache.org/r/35150/diff/
Testing
-------
make check
Thanks,
Paul Brett
Re: Review Request 35150: Add output stream operation for handle to
use in port_mapping.cpp
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35150/#review86861
-----------------------------------------------------------
Ship it!
src/linux/routing/handle.hpp
<https://reviews.apache.org/r/35150/#comment138976>
2 lines apart.
src/linux/routing/handle.hpp
<https://reviews.apache.org/r/35150/#comment138977>
Ditto.
- Jie Yu
On June 5, 2015, 8:30 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35150/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:30 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Bugs: MESOS-2821
> https://issues.apache.org/jira/browse/MESOS-2821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add output stream operation for handle to use in port_mapping.cpp
>
>
> Diffs
> -----
>
> src/linux/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10
>
> Diff: https://reviews.apache.org/r/35150/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Paul Brett
>
>