You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/10/02 02:12:19 UTC
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14342
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Ongoing TestWorkloads don't like it when the only master gets restarted. That
made the test fail with such errors as:
F1002 01:26:04.854351 26289 test_workload.cc:255] Network error: LookupRpc { table: 'test-workload', partition-key: (RANGE (key): 1143140152), attempt: 1 } failed: Client connection negotiation failed: client connection to 127.25.46.190:34359: connect: Connection refused (error 111)
So I've cut the workload short; it's not crucial to the test. Without
this, this failed 3/5000 times in debug mode. With it, it passed
4999/5000 times (failure due to KUDU-2431).
Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
---
M src/kudu/integration-tests/maintenance_mode-itest.cc
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/14342/1
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 )
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG@9
PS1, Line 9: TestWorkloads don't like it when the only master gets restarted
> Is that universally true for any test scenario? If so, maybe open a JIRA t
ClientFailoverITest_TestClusterCrashDuringWorkload has to deal with this too, and it configures network_error_allowed(true) and timeout_allowed(true) on the workload. Would that be appropriate here?
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 03:55:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14342
to look at the new patch set (#2).
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Ongoing TestWorkloads don't like it when the only master gets restarted. That
made the test fail with such errors as:
F1002 01:26:04.854351 26289 test_workload.cc:255] Network error: LookupRpc { table: 'test-workload', partition-key: (RANGE (key): 1143140152), attempt: 1 } failed: Client connection negotiation failed: client connection to 127.25.46.190:34359: connect: Connection refused (error 111)
So I've allowed network errors in the TestWorkload. Without this, this
failed 3/5000 times in debug mode. With it, it passed 4999/5000 times
(failure due to KUDU-2431).
Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
---
M src/kudu/integration-tests/maintenance_mode-itest.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/14342/2
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 )
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 04:55:52 +0000
Gerrit-HasComments: No
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 )
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG@9
PS1, Line 9: TestWorkloads don't like it when the only master gets restarted
Is that universally true for any test scenario? If so, maybe open a JIRA to track it and fix eventually (probably, as a newbie item)?
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 02:26:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14342 )
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14342/1//COMMIT_MSG@9
PS1, Line 9: TestWorkloads don't like it when the only master gets restarted
> ClientFailoverITest_TestClusterCrashDuringWorkload has to deal with this to
Done
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 04:39:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14342 )
Change subject: test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
......................................................................
test: deflake TestFailedTServerInMaintenanceModeDoesntRereplicate
Ongoing TestWorkloads don't like it when the only master gets restarted. That
made the test fail with such errors as:
F1002 01:26:04.854351 26289 test_workload.cc:255] Network error: LookupRpc { table: 'test-workload', partition-key: (RANGE (key): 1143140152), attempt: 1 } failed: Client connection negotiation failed: client connection to 127.25.46.190:34359: connect: Connection refused (error 111)
So I've allowed network errors in the TestWorkload. Without this, this
failed 3/5000 times in debug mode. With it, it passed 4999/5000 times
(failure due to KUDU-2431).
Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Reviewed-on: http://gerrit.cloudera.org:8080/14342
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/maintenance_mode-itest.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9f52a65ea76996c503f922af3e068048142e5f5
Gerrit-Change-Number: 14342
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)