You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/12/04 04:56:48 UTC
[GitHub] [kylin] zhangayqian commented on a change in pull request #1496: KYLIN-4817 Refine CubeMigrationCLI for kylin4
zhangayqian commented on a change in pull request #1496:
URL: https://github.com/apache/kylin/pull/1496#discussion_r535835955
##########
File path: kylin-spark-project/kylin-spark-common/src/main/java/org/apache/kylin/engine/spark/metadata/cube/PathManager.java
##########
@@ -49,6 +49,12 @@ public static String getSegmentParquetStoragePath(CubeInstance cube, String segN
return hdfsWorkDir + "parquet" + File.separator + cube.getName() + File.separator + segName + "_" + identifier;
}
+ public static String getSegmentParquetStoragePath(String hdfsWorkDir, String cubeName, CubeSegment segment) {
+ String segmentName = segment.getName();
+ String identifier = segment.getStorageLocationIdentifier();
+ return hdfsWorkDir + "parquet" + File.separator + cubeName + File.separator + segmentName + "_" + identifier;
Review comment:
Actually the end of `hdfsWorkDir` already comes with a File.separator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org