You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/10/16 16:33:21 UTC

Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/
-----------------------------------------------------------

Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.


Bugs: AMBARI-22244
    https://issues.apache.org/jira/browse/AMBARI-22244


Repository: ambari


Description
-------

Replaced `serviceName` with `serviceType` in `getService` and `getComponent` calls where found to be necessary.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
  ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java 45cc97348e89cdf5bd73a5d4d6139f808bc23180 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java 60230f6b9fe476deed40ed0f4083ec24bea742f5 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java 69492574f8756006c9bd7aab495efb269265cfb7 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 5ecce88a84bb8897788fe881f0059fcb553c776f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java e12477eede7176a19b456294602f91d44a35ad61 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 28b5c28e848720191ddcdf142d52c862755eaab0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java ca80961ab3634960e8f12cc56b876109afae33ec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 252d7726e392307e1a8a0688b8de4e95e4982e8e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8c2198bc185da616200bf2701acd4cb8a31f7022 
  ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java cae330b3466982923deb388ac5323c67fffea02d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 603e650894ab27d12cbe2b9c49daf299e5818d5f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 5e23f0b592519746c111dd89afbda37a79c425b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java f73d7c98ef6639fa7feaea4399b39b8b6b70a7e0 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java 053fb5417ddd09a98a66a1bdf45ca0e569b5ed4e 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 4846eb1d68049965615ab4366adf32c5e9b1f4be 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java e5298dc629262aca4472c58d7d7abd2e7a63720a 
  ambari-server/src/main/java/org/apache/ambari/server/mpack/MpackManager.java 0fcc28565d26ee0e9459b8329a0b64fbc4c2bde1 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d6876d9881116711eafb95eaa0e1901a6b870664 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 58b0300b0b6cf15144d4bcd541671d962e074096 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java df6437eab7a78afe734c78475b4c924944436d6c 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 70344b0a2e8428b5d3586dd77eeca20112bf7a8e 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8f9d8e1b0b430e4c11e6935d2b7cbe3bedadd874 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 15f7048ab0f1682dd840d5e917b22148d0355e00 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 3bde889b4b9fa10203b38f06f18dd6ae707e9809 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 13ceeb914bf336d207e95b9ab018471b0c2e882d 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java acf0639f9359393dc3f569ad1f43484bd45213d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 9c47e5d541e60d0ac843e0bc3341fea3467c9d7a 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 6190a03b8bae92519752a171f9d466bfb38e7218 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 7edabc6df0db3feb978f2d2ba105cabbc1c34570 


Diff: https://reviews.apache.org/r/63034/diff/1/


Testing
-------

Manual testing:
 * create 2 services for same service type (POST)
 * create a component for each service (POST)
 * query service (GET)
 * query component (GET)

More API testing in progress.


Thanks,

Attila Doroszlai


Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63034/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 1:42 p.m.)


Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.


Bugs: AMBARI-22244
    https://issues.apache.org/jira/browse/AMBARI-22244


Repository: ambari


Description
-------

Replaced `serviceName` with `serviceType` in `getService` and `getComponent` calls where found to be necessary.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java bb298d5a5ceda4619de958c7a529101c6e4f2e3f 
  ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java 45cc97348e89cdf5bd73a5d4d6139f808bc23180 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 2bb450bd0ac6a0da064d892e74bbdd05e2475dd6 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java 60230f6b9fe476deed40ed0f4083ec24bea742f5 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java 69492574f8756006c9bd7aab495efb269265cfb7 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 5ecce88a84bb8897788fe881f0059fcb553c776f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 0f6eb90803ca6b7a5fb9791294a269aaf4e45fb9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java e12477eede7176a19b456294602f91d44a35ad61 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 28b5c28e848720191ddcdf142d52c862755eaab0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java ca80961ab3634960e8f12cc56b876109afae33ec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ba5a4e78aebb49dbcc24d220c35abfd46fe3dbc0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java f7559c6d3422f4902e28b4f205564bc0ac0aaefa 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java ba5fccc1dc1d6ace00ba0f9f36820b055a66ce3b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 252d7726e392307e1a8a0688b8de4e95e4982e8e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8c2198bc185da616200bf2701acd4cb8a31f7022 
  ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java 0cd55c31a90a17bcd3a8b17783156dc92b2a6a57 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java cae330b3466982923deb388ac5323c67fffea02d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java e3f4e1a005c358ef5a7801691b56c9b91c9aaa11 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java 603e650894ab27d12cbe2b9c49daf299e5818d5f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java 765e6fcaaa75086d2bc37e058b6e69e1268be8c2 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java 704b4b96fbe5b54a7c36c22280f27142c0a8cfe9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java 5e23f0b592519746c111dd89afbda37a79c425b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java 6c5eab4090a18dce7cea29d8d5038d5ad964fe1c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java 2fd99e48c34605cd2e28ffdba0c2ea40fe6b49ab 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java f73d7c98ef6639fa7feaea4399b39b8b6b70a7e0 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java 053fb5417ddd09a98a66a1bdf45ca0e569b5ed4e 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 4846eb1d68049965615ab4366adf32c5e9b1f4be 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java e5298dc629262aca4472c58d7d7abd2e7a63720a 
  ambari-server/src/main/java/org/apache/ambari/server/mpack/MpackManager.java 0fcc28565d26ee0e9459b8329a0b64fbc4c2bde1 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d6876d9881116711eafb95eaa0e1901a6b870664 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 58b0300b0b6cf15144d4bcd541671d962e074096 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java df6437eab7a78afe734c78475b4c924944436d6c 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 70344b0a2e8428b5d3586dd77eeca20112bf7a8e 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 8f9d8e1b0b430e4c11e6935d2b7cbe3bedadd874 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 15f7048ab0f1682dd840d5e917b22148d0355e00 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 3bde889b4b9fa10203b38f06f18dd6ae707e9809 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 13ceeb914bf336d207e95b9ab018471b0c2e882d 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java acf0639f9359393dc3f569ad1f43484bd45213d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 9c47e5d541e60d0ac843e0bc3341fea3467c9d7a 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 6190a03b8bae92519752a171f9d466bfb38e7218 
  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java 7edabc6df0db3feb978f2d2ba105cabbc1c34570 


Diff: https://reviews.apache.org/r/63034/diff/1/


Testing (updated)
-------

Manual testing:
 * create 2 services for same service type (POST)
 * create a component for each service (POST)
 * query service (GET)
 * query component (GET)


Thanks,

Attila Doroszlai