[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10398: fix: dataset list filters bug

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #10398:
URL: https://github.com/apache/incubator-superset/pull/10398#discussion_r459089256



##########
File path: superset-frontend/src/components/TableSelector.jsx
##########
@@ -274,12 +274,15 @@ export default class TableSelector extends React.PureComponent {
   }
 
   renderDatabaseSelect() {
+    const filters = this.props.formMode
+      ? ''
+      : 'filters:!((col:expose_in_sqllab,opr:eq,value:!t)),';

Review comment:
       Not sure what we've been doing so far around building API GET urls, but generally I would rather see `rison.encode` used against JS data structures instead of raw `rison` as many engs may not be familiar with `rison`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org