You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/26 12:19:54 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #15098: Revise YamlProxyConfigurationSwapperTest
terrymanu opened a new pull request #15098:
URL: https://github.com/apache/shardingsphere/pull/15098
Revise #15085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #15098: Revise YamlProxyConfigurationSwapperTest
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #15098:
URL: https://github.com/apache/shardingsphere/pull/15098#discussion_r792585320
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/test/resources/conf/swap/config-readwrite-splitting.yaml
##########
@@ -32,15 +32,14 @@ dataSources:
rules:
- !READWRITE_SPLITTING
dataSources:
- pr_ds:
+ readwrite_ds:
Review comment:
nice fix. unmeaninful naming is really annoying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #15098: Revise YamlProxyConfigurationSwapperTest
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #15098:
URL: https://github.com/apache/shardingsphere/pull/15098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #15098: Revise YamlProxyConfigurationSwapperTest
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #15098:
URL: https://github.com/apache/shardingsphere/pull/15098#discussion_r792585320
##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/test/resources/conf/swap/config-readwrite-splitting.yaml
##########
@@ -32,15 +32,14 @@ dataSources:
rules:
- !READWRITE_SPLITTING
dataSources:
- pr_ds:
+ readwrite_ds:
Review comment:
nice fix. unmeaningful naming is really annoying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org