You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Pil0tXia (via GitHub)" <gi...@apache.org> on 2023/07/26 08:07:30 UTC
[GitHub] [eventmesh-site] Pil0tXia opened a new pull request, #110: [ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response
Pil0tXia opened a new pull request, #110:
URL: https://github.com/apache/eventmesh-site/pull/110
Fixes #109.

When inserting the config, the path contains `manufacturerName`, and the same logic applies when querying. Therefore, if we follow the request example in the documentation, it will result in an NPE (NullPointerException).

There are two possible solutions, with no impact on users. One way is to retrieve `manufacturerName` from `callbackPath` when making a query on our end. However, this would require specifying in the documentation that `manufacturerName` must be included in users' `callbackPath`, which doesn't seem like a common practice.
A simpler solution is to include `manufacturerName` in the request. Since there are likely no users for our webhook at the moment, I will go with the latter option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh-site] xwm1992 merged pull request #110: [ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response & Optimize Hard-coding
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #110:
URL: https://github.com/apache/eventmesh-site/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh-site] Pil0tXia commented on pull request #110: [ISSUE #109] queryWebHookConfigById endpoint causes NPE and returns empty response
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #110:
URL: https://github.com/apache/eventmesh-site/pull/110#issuecomment-1651333107
Commits below are synchronised modifications of this issue: [Enhancement] Optimize Webhook Manufacturer source Hard-coding https://github.com/apache/eventmesh/issues/4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org