[GitHub] [guacamole-client] mike-jumper commented on pull request #546: GUACAMOLE-1123: Standardize REST endpoints for historical data

[GitBox <gi...@apache.org>]

mike-jumper commented on pull request #546:
URL: https://github.com/apache/guacamole-client/pull/546#issuecomment-686798000


   > I think the only other thing I'm unsure about at this point is whether passing around the `null` identifier is the best way to go. It keeps the code as lean as possible by leveraging the existing MyBatis classes and queries without the need for additional queries, and still leverages the database to filter the data (which should be the fastest/most efficient way to accomplish that), but passing around `null` feels a little strange. Is that okay, or should I take a different approach, there - like just pulling all the records from the DB and doing some filtering within a Java class?
   
   So long as the meaning of `null` is well documented, I think this is fine. For functions which accept multiple possible criteria to narrow a result, the pattern of leveraging `null` as a wildcard is pretty common, and I'm all for leveraging a feature of MyBatis to keep things clean.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org