You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/05/10 12:29:53 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5931: upgrade to apache lucene 9.6.0 and maven-indexer 7.0.2
mbien opened a new pull request, #5931:
URL: https://github.com/apache/netbeans/pull/5931
draft until indexer 7.0.2 is actually released
- maven-indexer 7.0.2 fixed a bug which allows NB to cancel indexing in multi threaded mode and adds support for index filtering during extraction ([GH302](https://github.com/apache/maven-indexer/pull/302), [GH314](https://github.com/apache/maven-indexer/pull/314))
- lucene 9.6.0 adds support for the panama backend of MMapDirectory on JDK 19/20 ([GH12188](https://github.com/apache/lucene/pull/12188)) and many other improvements and fixes: https://lucene.apache.org/core/9_6_0/changes/Changes.html#v9.6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5931: upgrade to apache lucene 9.6.0 and maven-indexer 7.0.2 + more
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5931:
URL: https://github.com/apache/netbeans/pull/5931#discussion_r1192202440
##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -568,6 +568,16 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
// IllegalArgumentException signals remote archive format problems
fetchFailed = true;
throw new IOException("Failed to load maven-index for: " + indexingContext.getRepositoryUrl(), ex);
+ } catch (RuntimeException ex) {
+ // thread pools, like the one used in maven-indexer's IndexDataReader, may suppress cancellation exceptions
+ // lets try to find them again
+ if (isCancellation(ex)) {
+ Cancellation cancellation = new Cancellation();
+ cancellation.addSuppressed(ex);
+ throw cancellation;
+ } else {
+ throw ex;
+ }
Review Comment:
we can do this now since it was fixed upstream in 7.0.2: https://github.com/apache/maven-indexer/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5931: upgrade to apache lucene 9.6.0 and maven-indexer 7.0.2 + more
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5931:
URL: https://github.com/apache/netbeans/pull/5931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5931: upgrade to apache lucene 9.6.0 and maven-indexer 7.0.2
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5931:
URL: https://github.com/apache/netbeans/pull/5931#issuecomment-1542265409
everything green, removing all-tests label for updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5931: upgrade to apache lucene 9.6.0 and maven-indexer 7.0.2 + more
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5931:
URL: https://github.com/apache/netbeans/pull/5931#discussion_r1192202440
##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -568,6 +568,16 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
// IllegalArgumentException signals remote archive format problems
fetchFailed = true;
throw new IOException("Failed to load maven-index for: " + indexingContext.getRepositoryUrl(), ex);
+ } catch (RuntimeException ex) {
+ // thread pools, like the one used in maven-indexer's IndexDataReader, may suppress cancellation exceptions
+ // lets try to find them again
+ if (isCancellation(ex)) {
+ Cancellation cancellation = new Cancellation();
+ cancellation.addSuppressed(ex);
+ throw cancellation;
+ } else {
+ throw ex;
+ }
Review Comment:
we can do this now since it was fixed upstream in 7.0.2: https://github.com/apache/maven-indexer/pull/314
-> cancelling indexing in multi threaded mode works now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists