You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/05 05:04:56 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12630: [Broker] Check topic exists when executing postSchema

codelipenghui commented on a change in pull request #12630:
URL: https://github.com/apache/pulsar/pull/12630#discussion_r743392431



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java
##########
@@ -306,6 +308,29 @@ private static void handleGetAllSchemasResponse(AsyncResponse response, List<Sch
         }
     }
 
+    private void checkTopicExists(AsyncResponse response) {
+        pulsar().getNamespaceService().getListOfTopics(topicName.getNamespaceObject(),

Review comment:
       I think it's better to do not to add this check right now, if we have many topics under the namespace, this will bring more workload to Zookeeper.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org