[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2658: Core: Support relative paths in metadata

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #2658:
URL: https://github.com/apache/iceberg/pull/2658#discussion_r660000677



##########
File path: core/src/main/java/org/apache/iceberg/ManifestLists.java
##########
@@ -43,22 +47,54 @@ private ManifestLists() {
         .reuseContainers(false)
         .build()) {
 
-      return Lists.newLinkedList(files);
+      return shouldUseRelativePaths ? updateManifestFilePathsToAbsolutePaths(files,

Review comment:
       I believe this was commented on the issue as well, but shouldn't we always call updateManifestFilePathstoAbsolute here? Instead of passing through a boolean we could just see if we need to update any files and return the updated set? So a use with only absolute paths would essentially just pass through the list and not change anything?
   
   This would remove our requirement to pass through "shouldUseRelativePaths"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org