You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/17 21:36:07 UTC
[GitHub] [arrow] JamesNK commented on a change in pull request #8694: ARROW-10542: [C#][Flight] Add beginning on flight code for net core
JamesNK commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r525540207
##########
File path: csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
##########
@@ -0,0 +1,18 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <PropertyGroup>
+ <TargetFramework>netstandard2.1</TargetFramework>
+ <LangVersion>8.0</LangVersion>
+ </PropertyGroup>
+
+ <ItemGroup>
+ <PackageReference Include="Google.Protobuf" Version="3.14.0" />
+ <PackageReference Include="Grpc" Version="2.33.1" />
Review comment:
Only need the tooling, and only at build.
##########
File path: csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
##########
@@ -0,0 +1,18 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+ <PropertyGroup>
+ <TargetFramework>netstandard2.1</TargetFramework>
+ <LangVersion>8.0</LangVersion>
+ </PropertyGroup>
+
+ <ItemGroup>
+ <PackageReference Include="Google.Protobuf" Version="3.14.0" />
+ <PackageReference Include="Grpc" Version="2.33.1" />
Review comment:
```suggestion
<PackageReference Include="Grpc.Tools" Version="2.33.1" PrivateAssets="All" />
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org