You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/06 21:07:31 UTC
[GitHub] [incubator-druid] jon-wei edited a comment on issue #6865: Densify
swapped hll buffer
jon-wei edited a comment on issue #6865: Densify swapped hll buffer
URL: https://github.com/apache/incubator-druid/pull/6865#issuecomment-470276731
> For longer term fixes, I'm not even sure if documenting the existing HLL design is worth it. For example, simply saying "Legacy HLL implementation has a lot of rough corner cases that are handled by its successor Data Sketches HLL" or similar.
The 0.14.0 docs will deprecate the old HLL agg and point users to the DataSketches HLL instead: https://github.com/apache/incubator-druid/pull/7195
I'm okay with this PR being merged for 0.14.0, I think "avoid crashes in old HLL, use datasketches HLL for proper results" is a reasonable approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org