== New issue == #CRITICAL#

[Hamdi THABET <ha...@gmail.com>]

There is no sense to have two users / moderators / administrators with the
same email 

=> adding email test when adding a new user in the administration panel
(like ID test) 

New issue = https://issues.apache.org/jira/browse/OPENMEETINGS-185 

Réf. : Re: Réf. : Re: Réf. : Re: == New issue == #CRITICAL#

[Hamdi THABET <ha...@gmail.com>]

Okay Sebastian I understand what you want to say. And I'm convinced  :-)
I closed the issue. There is more critical improvements to do.

Re: Réf. : Re: Réf. : Re: == New issue == #CRITICAL#

["seba.wagner@gmail.com" <se...@gmail.com>]

Okay,

what I tried to say was that email is not unique in the database and such a
check if the same user with the same email does already exist or not will
have bad effects to other parts of the application.

If an administrator is not able to remember that he accidently added the
same user already then maybe he should check this differently.

So actually:
1) This is not critical at all
2) A potential check that email already exists before will have to check
much more then if the email already exists or not cause the same email can
be multiple times in the database with no problem as long as the duplicated
email is connected to an externalUser or the user is for example disabled
or marked as deleted.

Sebastian

2012/4/19 Hamdi THABET <ha...@gmail.com>

>    For Administration > Users , I mean that if the administrator add a
> new user with an existent email it will be better if we show a box to
> inform him and he has to modify the email to process the operation.
>
> An administrator can add, not intentionally, a new user with duplicate
> email. And this is not professional at all !
> Because this user will receive invitations email twice.
>



-- 
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.openmeetings.de
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com

Réf. : Re: Réf. : Re: == New issue == #CRITICAL#

[Hamdi THABET <ha...@gmail.com>]

For Administration > Users , I mean that if the administrator add a new user
with an existent email it will be better if we show a box to inform him and
he has to modify the email to process the operation.

An administrator can add, not intentionally, a new user with duplicate email
 And this is not professional at all !
Because this user will receive invitations email twice.   

Re: Réf. : Re: == New issue == #CRITICAL#

["seba.wagner@gmail.com" <se...@gmail.com>]

The email is actually not the identifier. The identifier is the userId,
and under some circumstance a unoque user can also be identified by the
combination of the fields: externalUserId + externalUserType

The rule for the email is as following:
It is not possible to sign up with the same id twice.

For Administration > Users I am not sure, but my point of view here is
basically that an administrator should be have the freedom to do what he
wants.

But still, you did not give us any steps on what we should do to reproduce
it. I mean there are around 5 different possibilities to enter a email. In
User Administration, in invitation, in private message center, in sign up.
Additionally you can use the SOAP/REST API to enter email addresses or use
the LDAP integration to sync emails to our database.
Or you can potentially use the Module integration to sync emails to the
database.

So where exactly did you enter the email ?

Btw: There are also situations where the email in the database is NOT
unique and it is a desired feature: When you use the OpenMeetings platform
standalone AND for example integrated with Moodle (or sugarCRM or whatever).
The process is that whenever a external user comes he will be synced to our
database. So if a user comes from Moodle or SugarCRM they can have the same
email => and that is also okay for us. No need to block anybody, cause in
that situation the external user is identified by its externalUserId and
externalUserType.

So as you see your assumption "email is _always_ unique in the database" is
actually not true.
It always depends on the type of user.

Sebastian

2012/4/19 Hamdi THABET <ha...@gmail.com>

>    What I meant is that the email address must be unique. Adding a new
> user with an existing email becomes impossible!
> Because the email must be unique within the database as the identifier ID
>
>
>


-- 
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.openmeetings.de
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com

Réf. : Re: == New issue == #CRITICAL#

[Hamdi THABET <ha...@gmail.com>]

What I meant is that the email address must be unique. Adding a new user
with an existing email becomes impossible!
Because the email must be unique within the database as the identifier ID

Re: == New issue == #CRITICAL#

["seba.wagner@gmail.com" <se...@gmail.com>]

Hi Hamdi,

can you please give exact details what is needed to reproduce your issue.
Your report actually makes not so much sense.

Sebastian

2012/4/19 Hamdi THABET <ha...@gmail.com>

>    There is no sense to have two users / moderators / administrators with
> the same email
>
> => adding email test when adding a new user in the administration
> panel (like ID test)
>
> New issue = https://issues.apache.org/jira/browse/OPENMEETINGS-185
>



-- 
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.openmeetings.de
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com