You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Honwai Wong (JIRA)" <ji...@apache.org> on 2009/11/11 14:43:39 UTC

[jira] Created: (SLING-1183) Log RepositoryException on debug level if obtaining JCR session fails

Log RepositoryException on debug level if obtaining JCR session fails
---------------------------------------------------------------------

                 Key: SLING-1183
                 URL: https://issues.apache.org/jira/browse/SLING-1183
             Project: Sling
          Issue Type: Improvement
          Components: Engine
    Affects Versions: Engine 2.0.4
            Reporter: Honwai Wong
            Priority: Minor


If the SlingAuthenticator#authenticate method is unable to obtain a JCR session based on the given credentials, a RepositoryException is caught silently without further notice on the exact root cause. While this is an expected behavior, a more verbose logging would be helpful for debugging purposes. Though the handleImpersonation method already provides some pointers as to the initial cause, I'd prefer to have the full stacktrace of the RepositoryException at hand.

I suggest to log the full RepositoryException on DEBUG level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-1183) Log RepositoryException on debug level if obtaining JCR session fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-1183.
------------------------------------


Close after release

> Log RepositoryException on debug level if obtaining JCR session fails
> ---------------------------------------------------------------------
>
>                 Key: SLING-1183
>                 URL: https://issues.apache.org/jira/browse/SLING-1183
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.4
>            Reporter: Honwai Wong
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: Engine 2.1.0
>
>
> If the SlingAuthenticator#authenticate method is unable to obtain a JCR session based on the given credentials, a RepositoryException is caught silently without further notice on the exact root cause. While this is an expected behavior, a more verbose logging would be helpful for debugging purposes. Though the handleImpersonation method already provides some pointers as to the initial cause, I'd prefer to have the full stacktrace of the RepositoryException at hand.
> I suggest to log the full RepositoryException on DEBUG level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1183) Log RepositoryException on debug level if obtaining JCR session fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1183.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: Engine 2.1.0

Fixed in Rev. 834886

> Log RepositoryException on debug level if obtaining JCR session fails
> ---------------------------------------------------------------------
>
>                 Key: SLING-1183
>                 URL: https://issues.apache.org/jira/browse/SLING-1183
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.4
>            Reporter: Honwai Wong
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: Engine 2.1.0
>
>
> If the SlingAuthenticator#authenticate method is unable to obtain a JCR session based on the given credentials, a RepositoryException is caught silently without further notice on the exact root cause. While this is an expected behavior, a more verbose logging would be helpful for debugging purposes. Though the handleImpersonation method already provides some pointers as to the initial cause, I'd prefer to have the full stacktrace of the RepositoryException at hand.
> I suggest to log the full RepositoryException on DEBUG level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1183) Log RepositoryException on debug level if obtaining JCR session fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776459#action_12776459 ] 

Felix Meschberger commented on SLING-1183:
------------------------------------------

I agree that adding the dump for debugging purposes is helpful. But for a correct resolution, I urge you to report Jackrabbit (or whatever repository you use) issues to enhance the LoginException with a meaningful message.

> Log RepositoryException on debug level if obtaining JCR session fails
> ---------------------------------------------------------------------
>
>                 Key: SLING-1183
>                 URL: https://issues.apache.org/jira/browse/SLING-1183
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.4
>            Reporter: Honwai Wong
>            Assignee: Felix Meschberger
>            Priority: Minor
>
> If the SlingAuthenticator#authenticate method is unable to obtain a JCR session based on the given credentials, a RepositoryException is caught silently without further notice on the exact root cause. While this is an expected behavior, a more verbose logging would be helpful for debugging purposes. Though the handleImpersonation method already provides some pointers as to the initial cause, I'd prefer to have the full stacktrace of the RepositoryException at hand.
> I suggest to log the full RepositoryException on DEBUG level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SLING-1183) Log RepositoryException on debug level if obtaining JCR session fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned SLING-1183:
----------------------------------------

    Assignee: Felix Meschberger

> Log RepositoryException on debug level if obtaining JCR session fails
> ---------------------------------------------------------------------
>
>                 Key: SLING-1183
>                 URL: https://issues.apache.org/jira/browse/SLING-1183
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.0.4
>            Reporter: Honwai Wong
>            Assignee: Felix Meschberger
>            Priority: Minor
>
> If the SlingAuthenticator#authenticate method is unable to obtain a JCR session based on the given credentials, a RepositoryException is caught silently without further notice on the exact root cause. While this is an expected behavior, a more verbose logging would be helpful for debugging purposes. Though the handleImpersonation method already provides some pointers as to the initial cause, I'd prefer to have the full stacktrace of the RepositoryException at hand.
> I suggest to log the full RepositoryException on DEBUG level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.