You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 02:54:53 UTC

[GitHub] [airflow] dstandish commented on a change in pull request #14121: Correction in 'Relationship Builders' section

dstandish commented on a change in pull request #14121:
URL: https://github.com/apache/airflow/pull/14121#discussion_r574225180



##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,12 @@ Relationship Builders
 
 *Moved in Airflow 2.0*
 
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
-``chain`` and ``cross_downstream`` function provide easier ways to set relationships
+:func:`airflow.models.baseoperator.chain` and :func:`airflow.models.baseoperator..cross_downstream` function provide easier ways to set relationships
 between operators in specific situation.
 
+.. versionchanged:: 2.0.0
+    Those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.

Review comment:
       ```suggestion
       They have been moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
   ```
   

##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -655,11 +655,12 @@ Relationship Builders
 
 *Moved in Airflow 2.0*
 
-In Airflow 2.0 those two methods moved from ``airflow.utils.helpers`` to ``airflow.models.baseoperator``.
-
-``chain`` and ``cross_downstream`` function provide easier ways to set relationships
+:func:`airflow.models.baseoperator.chain` and :func:`airflow.models.baseoperator..cross_downstream` function provide easier ways to set relationships
 between operators in specific situation.

Review comment:
       ```suggestion
   between tasks.
   ```
   "in specific situation" doesn't really say anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org