You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/04/01 03:57:34 UTC
[PR] [SPARK-56178][SQL] MSCK REPAIR TABLE for V2 file tables [spark]
LuciferYang opened a new pull request, #55129:
URL: https://github.com/apache/spark/pull/55129
### What changes were proposed in this pull request?
Implement `RepairTableExec` for V2 file tables to sync filesystem partition directories with the catalog metastore.
Changes:
- New `RepairTableExec`: scans filesystem partitions via `FileTable.listPartitionIdentifiers()`, compares with catalog, registers missing partitions and drops orphaned entries
- `DataSourceV2Strategy`: route `RepairTable` and `RecoverPartitions` for `FileTable` to the new V2 exec node (non-FileTable V2 tables still throw)
### Why are the changes needed?
After SPARK-56175 changed `V2SessionCatalog.loadTable` to return `FileTable` instead of `V1Table`, `MSCK REPAIR TABLE` and `ALTER TABLE RECOVER PARTITIONS` on file tables hit the V2 error path (`repairTableNotSupportedForV2TablesError`). A V2-native implementation is needed.
### Does this PR introduce _any_ user-facing change?
No. `MSCK REPAIR TABLE` and `ALTER TABLE RECOVER PARTITIONS` continue to work on file tables, now via the V2 path.
### How was this patch tested?
Added test in `FileDataSourceV2WriteSuite`:
- Create partitioned table, write data directly to filesystem partition directories, verify catalog has no partitions before repair, run `MSCK REPAIR TABLE`, verify 3 partitions registered in catalog and data is readable
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56178][SQL] MSCK REPAIR TABLE for V2 file tables [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #55129: [SPARK-56178][SQL] MSCK REPAIR TABLE for V2 file tables
URL: https://github.com/apache/spark/pull/55129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56178][SQL] MSCK REPAIR TABLE for V2 file tables [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #55129:
URL: https://github.com/apache/spark/pull/55129#issuecomment-4167258142
The actual change for the current patch is [a1742f5](https://github.com/apache/spark/pull/55129/commits/a1742f5445cce75c0d29af2d779c5b46354a959b), which is the **6th patch** in **SPARK-56170**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56178][SQL] MSCK REPAIR TABLE for V2 file tables [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55129:
URL: https://github.com/apache/spark/pull/55129#issuecomment-5013557202
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org