You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/04 00:49:51 UTC

[GitHub] [logging-log4cxx] rm5248 commented on a diff in pull request #117: Prevent MSVC 'needs to have a dll interface' warnings

rm5248 commented on code in PR #117:
URL: https://github.com/apache/logging-log4cxx/pull/117#discussion_r962224217


##########
src/main/include/log4cxx/log4cxx.h.in:
##########
@@ -64,8 +64,15 @@ typedef unsigned int log4cxx_uint32_t;
 	typedef std::weak_ptr<T> T##WeakPtr
 #define LOG4CXX_UNIQUE_PTR_DEF(T) typedef std::unique_ptr<T> T##UniquePtr;
 #define LOG4CXX_LIST_DEF(N, T) typedef std::vector<T> N
+#define LOG4CXX_PRIVATE_PTR(T) std::unique_ptr<T>

Review Comment:
   It feels like it doesn't really add anything in terms of making things simpler to read(to me).
   
   Not really a huge issue, more of a preference thing in how to organize the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org