You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2021/05/03 09:24:24 UTC

Review Request 73328: RANGER-3272 : Zone tag policies are getting deleted when zone is updated

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73328/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, and Vishal Suvagia.


Bugs: RANGER-3272
    https://issues.apache.org/jira/browse/RANGER-3272


Repository: ranger


Description
-------

Zone tag policies are getting deleted when zone is updated

Steps to reproduce : 
1.Create a zone with tag service and some service like yarn service.
2.Create a tag policy in zone
3.Edit the zone by adding new service like hive service with existing service.
4.Click on save
5.Check the tag policy created in step 2. The tag policy gets deleted


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java b62e0a5e3 


Diff: https://reviews.apache.org/r/73328/diff/1/


Testing
-------

Verified the same, now zone tag policies are not getting deleted after zone update.


Thanks,

Mateen Mansoori


Re: Review Request 73328: RANGER-3272 : Zone tag policies are getting deleted when zone is updated

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73328/#review222938
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On May 3, 2021, 9:24 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73328/
> -----------------------------------------------------------
> 
> (Updated May 3, 2021, 9:24 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, and Vishal Suvagia.
> 
> 
> Bugs: RANGER-3272
>     https://issues.apache.org/jira/browse/RANGER-3272
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Zone tag policies are getting deleted when zone is updated
> 
> Steps to reproduce : 
> 1.Create a zone with tag service and some service like yarn service.
> 2.Create a tag policy in zone
> 3.Edit the zone by adding new service like hive service with existing service.
> 4.Click on save
> 5.Check the tag policy created in step 2. The tag policy gets deleted
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java b62e0a5e3 
> 
> 
> Diff: https://reviews.apache.org/r/73328/diff/1/
> 
> 
> Testing
> -------
> 
> Verified the same, now zone tag policies are not getting deleted after zone update.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>


Re: Review Request 73328: RANGER-3272 : Zone tag policies are getting deleted when zone is updated

Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73328/#review222940
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Shah


On May 3, 2021, 9:24 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73328/
> -----------------------------------------------------------
> 
> (Updated May 3, 2021, 9:24 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, and Vishal Suvagia.
> 
> 
> Bugs: RANGER-3272
>     https://issues.apache.org/jira/browse/RANGER-3272
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Zone tag policies are getting deleted when zone is updated
> 
> Steps to reproduce : 
> 1.Create a zone with tag service and some service like yarn service.
> 2.Create a tag policy in zone
> 3.Edit the zone by adding new service like hive service with existing service.
> 4.Click on save
> 5.Check the tag policy created in step 2. The tag policy gets deleted
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java b62e0a5e3 
> 
> 
> Diff: https://reviews.apache.org/r/73328/diff/1/
> 
> 
> Testing
> -------
> 
> Verified the same, now zone tag policies are not getting deleted after zone update.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>