You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gr...@apache.org on 2023/09/29 17:23:01 UTC
[logging-chainsaw] 01/02: used generics instead of raw types
This is an automated email from the ASF dual-hosted git repository.
grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git
commit 576d0ef0b38a6ee7587041a85c4a96608f9e5155
Author: Christian Grobmeier <cg...@grobmeier.de>
AuthorDate: Fri Sep 29 19:22:29 2023 +0200
used generics instead of raw types
---
src/main/java/org/apache/log4j/chainsaw/LogUI.java | 27 ++++++++++------------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/src/main/java/org/apache/log4j/chainsaw/LogUI.java b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
index 0fcb688..c6dc35a 100644
--- a/src/main/java/org/apache/log4j/chainsaw/LogUI.java
+++ b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
@@ -722,11 +722,11 @@ public class LogUI extends JFrame {
Action showHiddenTabsAction =
new AbstractAction("Show All Hidden") {
public void actionPerformed(ActionEvent e) {
- for (Object o : getPanels().entrySet()) {
- Map.Entry entry = (Map.Entry) o;
- Boolean docked = (Boolean) entry.getValue();
- if (docked) {
- String identifier = (String) entry.getKey();
+
+ for (Map.Entry<String, Boolean> entry : getPanels().entrySet()) {
+ Boolean docked = entry.getValue();
+ if (Boolean.TRUE.equals(docked)) {
+ String identifier = entry.getKey();
int count = getTabbedPane().getTabCount();
boolean found = false;
@@ -735,7 +735,6 @@ public class LogUI extends JFrame {
if (name.equals(identifier)) {
found = true;
-
break;
}
}
@@ -1302,19 +1301,17 @@ public class LogUI extends JFrame {
aboutBox.setVisible(true);
}
- Map getPanels() {
- Map m = new HashMap();
+ Map<String, Boolean> getPanels() {
+ Map<String, Boolean> result = new HashMap<>();
Set<Map.Entry<String, Component>> panelSet = getPanelMap().entrySet();
- for (Object aPanelSet : panelSet) {
- Map.Entry entry = (Map.Entry) aPanelSet;
- Object o = entry.getValue();
- boolean valueToSend;
- valueToSend = !(o instanceof LogPanel) || ((DockablePanel) entry.getValue()).isDocked();
- m.put(entry.getKey(), valueToSend);
+ for (Map.Entry<String, Component> panel : panelSet) {
+ Component component = panel.getValue();
+ boolean value = !(component instanceof LogPanel) || ((DockablePanel) panel.getValue()).isDocked();
+ result.put(panel.getKey(), value);
}
- return m;
+ return result;
}
void displayPanel(String panelName, boolean display) {