You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "kaashif (via GitHub)" <gi...@apache.org> on 2024/06/09 03:35:21 UTC

[PR] [PYTHON] Fix pyspark.sql.functions.reduce docstring typo [spark]

kaashif opened a new pull request, #46923:
URL: https://github.com/apache/spark/pull/46923

   ### What changes were proposed in this pull request?
   
   This PR fixes a mistake in the docstring for `pyspark.sql.functions.reduce`. The parameter to the function is called `initialValue` not `zero` - there is no other mention of `zero` on the page, so it must be a mistake and should be `initialValue`.
   
   ### Why are the changes needed?
   
   The docstring is incorrect.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   
   ### How was this patch tested?
   
   N/A
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][PYTHON][DOCS] Fix pyspark.sql.functions.reduce docstring typo [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #46923:
URL: https://github.com/apache/spark/pull/46923#issuecomment-2171991125

   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [MINOR][PYTHON][DOCS] Fix pyspark.sql.functions.reduce docstring typo [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #46923: [MINOR][PYTHON][DOCS] Fix pyspark.sql.functions.reduce docstring typo
URL: https://github.com/apache/spark/pull/46923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [PYTHON] Fix pyspark.sql.functions.reduce docstring typo [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #46923:
URL: https://github.com/apache/spark/pull/46923#issuecomment-2167652003

   thanks for this fix. would you mind enabling the github action? 
   you may refer to the `Pull request` section in https://spark.apache.org/contributing.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org