[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

["Zili Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000653#comment-17000653 ] 

Zili Chen commented on FLINK-15307:
-----------------------------------

cc [~zhuzh] what do you think of this?

> Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-15307
>                 URL: https://issues.apache.org/jira/browse/FLINK-15307
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Configuration
>    Affects Versions: 1.9.0, 1.9.1, 1.10.0
>            Reporter: andrew.D.lin
>            Priority: Minor
>         Attachments: image-2019-12-18-14-59-03-181.png
>
>
> Subclasses of RestartStrategy
>  * FailingRestartStrategy
>  * FailureRateRestartStrategy
>  * FixedDelayRestartStrategy
>  * InfiniteDelayRestartStrategy
> Implementation class of FailoverStrategy
>  * AdaptedRestartPipelinedRegionStrategyNG
>  * RestartAllStrategy
>  * RestartIndividualStrategy
>  * RestartPipelinedRegionStrategy
>  
> FailoverStrategy describes how the job computation recovers from task failures.
> I think the following names may be easier to understand and easier to distinguish：
> Implementation class of FailoverStrategy
>  * AdaptedPipelinedRegionFailoverStrategyNG
>  * FailoverAllStrategy
>  * FailoverIndividualStrategy
>  * FailoverPipelinedRegionStrategy
> FailoverStrategy is currently generated by configuration. If we change the name of the implementation class, it will not affect compatibility.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)