You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2015/07/30 17:26:07 UTC
[jira] [Updated] (THRIFT-3068) C++ cppcheck warnings
[ https://issues.apache.org/jira/browse/THRIFT-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King, III updated THRIFT-3068:
---------------------------------------
Description:
These warnings were identified by cppcheck-1.69 on the thrift-0.9.3 codebase as of July 30 2015. Many of them are inconsequential, and some may be intentional for performance:
{noformat}[lib/cpp/src/thrift/async/TAsyncProcessor.h:62]: (warning) Member variable 'TAsyncProcessor::asyncServer_' is not initialized in the constructor.
[lib/cpp/src/thrift/concurrency/FunctionRunner.h:82]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
[lib/cpp/src/thrift/concurrency/FunctionRunner.h:89]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
[lib/cpp/src/thrift/protocol/TJSONProtocol.h:262]: (warning) Member variable 'LookaheadReader::data_' is not initialized in the constructor.
[lib/cpp/src/thrift/server/TNonblockingServer.cpp:1430]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'long'.
[lib/cpp/src/thrift/transport/TFileTransport.h:96]: (warning) Member variable 'readState::eventSizeBuff_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnRead_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnWrite_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:299] -> [lib/cpp/src/thrift/transport/TTransportUtils.h:200]: (warning) The class 'TPipedFileReaderTransport' defines member variable with name 'srcTrans_' also defined in its parent class 'TPipedTransport'.
{noformat}
The last one is curious enough that I filed this as a minor instead of a trivial defect to investigate.
was:
These warnings were identified by cppcheck-1.68 on the thrift-0.9.2 codebase. Many of them are inconsequential, and some may be intentional for performance:
{noformat}[lib/cpp/src/thrift/async/TAsyncProcessor.h:62]: (warning) Member variable 'TAsyncProcessor::asyncServer_' is not initialized in the constructor.
[lib/cpp/src/thrift/concurrency/FunctionRunner.h:82]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
[lib/cpp/src/thrift/concurrency/FunctionRunner.h:89]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
[lib/cpp/src/thrift/protocol/TJSONProtocol.h:262]: (warning) Member variable 'LookaheadReader::data_' is not initialized in the constructor.
[lib/cpp/src/thrift/server/TNonblockingServer.cpp:1430]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'long'.
[lib/cpp/src/thrift/transport/TFileTransport.h:96]: (warning) Member variable 'readState::eventSizeBuff_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnRead_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnWrite_' is not initialized in the constructor.
[lib/cpp/src/thrift/transport/TTransportUtils.h:299] -> [lib/cpp/src/thrift/transport/TTransportUtils.h:200]: (warning) The class 'TPipedFileReaderTransport' defines member variable with name 'srcTrans_' also defined in its parent class 'TPipedTransport'.
{noformat}
The last one is curious enough that I filed this as a minor instead of a trivial defect to investigate.
> C++ cppcheck warnings
> ---------------------
>
> Key: THRIFT-3068
> URL: https://issues.apache.org/jira/browse/THRIFT-3068
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Priority: Minor
>
> These warnings were identified by cppcheck-1.69 on the thrift-0.9.3 codebase as of July 30 2015. Many of them are inconsequential, and some may be intentional for performance:
> {noformat}[lib/cpp/src/thrift/async/TAsyncProcessor.h:62]: (warning) Member variable 'TAsyncProcessor::asyncServer_' is not initialized in the constructor.
> [lib/cpp/src/thrift/concurrency/FunctionRunner.h:82]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
> [lib/cpp/src/thrift/concurrency/FunctionRunner.h:89]: (warning) Member variable 'FunctionRunner::intervalMs_' is not initialized in the constructor.
> [lib/cpp/src/thrift/protocol/TJSONProtocol.h:262]: (warning) Member variable 'LookaheadReader::data_' is not initialized in the constructor.
> [lib/cpp/src/thrift/server/TNonblockingServer.cpp:1430]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'long'.
> [lib/cpp/src/thrift/transport/TFileTransport.h:96]: (warning) Member variable 'readState::eventSizeBuff_' is not initialized in the constructor.
> [lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnRead_' is not initialized in the constructor.
> [lib/cpp/src/thrift/transport/TTransportUtils.h:91]: (warning) Member variable 'TPipedTransport::pipeOnWrite_' is not initialized in the constructor.
> [lib/cpp/src/thrift/transport/TTransportUtils.h:299] -> [lib/cpp/src/thrift/transport/TTransportUtils.h:200]: (warning) The class 'TPipedFileReaderTransport' defines member variable with name 'srcTrans_' also defined in its parent class 'TPipedTransport'.
> {noformat}
> The last one is curious enough that I filed this as a minor instead of a trivial defect to investigate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)