You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/06/20 23:55:05 UTC

[GitHub] spark pull request #21548: [SPARK-24518][CORE] Using Hadoop credential provi...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21548#discussion_r196974952
  
    --- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
    @@ -179,9 +185,11 @@ private[spark] object SSLOptions extends Logging {
             .orElse(defaults.flatMap(_.keyStore))
     
         val keyStorePassword = conf.getWithSubstitution(s"$ns.keyStorePassword")
    +        .orElse(Option(hadoopConf.getPassword(s"$ns.keyStorePassword")).map(new String(_)))
    --- End diff --
    
    Needs charset (also in others).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org