You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/14 20:28:51 UTC
[GitHub] [tvm] vegaluisjose opened a new pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
vegaluisjose opened a new pull request #7286:
URL: https://github.com/apache/tvm/pull/7286
@liangfu @tmoreau89
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #7286:
URL: https://github.com/apache/tvm/pull/7286#discussion_r562375277
##########
File path: tests/python/contrib/test_verilator/infrastructure.py
##########
@@ -66,10 +68,43 @@ def offload(mod):
return mod
+def verilator_app_path():
Review comment:
Hey @liangfu
Yeah that is the plan, once we merge this. The idea is to finally update that PR that we have open for CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #7286:
URL: https://github.com/apache/tvm/pull/7286#discussion_r562375277
##########
File path: tests/python/contrib/test_verilator/infrastructure.py
##########
@@ -66,10 +68,43 @@ def offload(mod):
return mod
+def verilator_app_path():
Review comment:
Hey @liangfu
Yeah that is the plan, once we merge this. The idea is to finally update that PR that we have open for CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] liangfu commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
liangfu commented on a change in pull request #7286:
URL: https://github.com/apache/tvm/pull/7286#discussion_r562358753
##########
File path: tests/python/contrib/test_verilator/infrastructure.py
##########
@@ -66,10 +68,43 @@ def offload(mod):
return mod
+def verilator_app_path():
Review comment:
I don't think it's actually running in the CI (see https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7286/6/pipeline/255#step-340-log-91), would be better if we could enable testing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] liangfu commented on a change in pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
liangfu commented on a change in pull request #7286:
URL: https://github.com/apache/tvm/pull/7286#discussion_r562358753
##########
File path: tests/python/contrib/test_verilator/infrastructure.py
##########
@@ -66,10 +68,43 @@ def offload(mod):
return mod
+def verilator_app_path():
Review comment:
I don't think it's actually running in the CI (see https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7286/6/pipeline/255#step-340-log-91), would be better if we could enable testing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7286:
URL: https://github.com/apache/tvm/pull/7286#issuecomment-763883831
@tqchen I'd love some input on this if you have time to review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #7286: [BYOC][Verilator] add support to dynamically load hardware library
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7286:
URL: https://github.com/apache/tvm/pull/7286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org