You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/07 18:53:07 UTC
[GitHub] [incubator-dolphinscheduler] Ts686 opened a new pull request #4998: [Improvement-4971][alert|dao|service]
Ts686 opened a new pull request #4998:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4998
1. Remove redundant PropertyUtils.class (#4971)
2. Remove useless import package.
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] Ts686 closed pull request #4998: [Improvement-4971][alert|dao|service]
Posted by GitBox <gi...@apache.org>.
Ts686 closed pull request #4998:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4998: [Improvement-4971][alert|dao|service]
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4998:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4998#issuecomment-793872350
1: You need to delete the PropertyUtils.class file of alert and server, and only keep the PropertyUtils.class file in common.
2: When the alert or server starts, you need to call PropertyUtilsClass to load the relevant configuration files.
3: The problem of multiple loading may be involved, so you need to make a control judgment here. Modify the static loading module in PropertyUtils.class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4998: [Improvement-4971][alert|dao|service]
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4998:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4998#issuecomment-792387456
In addition to alert, other modules also have duplicate Properties. We still need to delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org