You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/11 11:32:13 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #15316: Add links to new modules for deprecated modules

kaxil commented on a change in pull request #15316:
URL: https://github.com/apache/airflow/pull/15316#discussion_r611174087



##########
File path: airflow/operators/redshift_to_s3_operator.py
##########
@@ -32,10 +32,9 @@
 
 
 class RedshiftToS3Transfer(RedshiftToS3Operator):
-    """This class is deprecated.
-
-    Please use:
-    `airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.
+    """
+    This class is deprecated.
+    Please use: :mod:`airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.

Review comment:
       ```suggestion
       Please use: :class:`airflow.providers.amazon.aws.transfers.redshift_to_s3.RedshiftToS3Operator`.
   ```

##########
File path: airflow/contrib/hooks/gcp_compute_hook.py
##########
@@ -31,7 +31,7 @@
 class GceHook(ComputeEngineHook):
     """
     This class is deprecated.
-    Please use ``airflow.providers.google.cloud.hooks.compute.ComputeEngineHook``.
+    Please use `airflow.providers.google.cloud.hooks.compute.ComputeEngineHook`.

Review comment:
       ```suggestion
       Please use :class:`airflow.providers.google.cloud.hooks.compute.ComputeEngineHook`.
   ```

##########
File path: airflow/contrib/hooks/gcp_dataflow_hook.py
##########
@@ -29,7 +29,10 @@
 
 
 class DataFlowHook(DataflowHook):
-    """This class is deprecated. Please use `airflow.providers.google.cloud.hooks.dataflow.DataflowHook`."""
+    """
+    This class is deprecated.
+    Please use `airflow.providers.google.cloud.hooks.dataflow.DataflowHook`.

Review comment:
       ```suggestion
       Please use :class:`airflow.providers.google.cloud.hooks.dataflow.DataflowHook`.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org