[GitHub] [incubator-doris] huangmengbin commented on a change in pull request #5991: [Bug] Fix range partition pruner bug

[GitBox <gi...@apache.org>]

huangmengbin commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-doris/pull/5991#discussion_r672842686



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/RangePartitionPruner.java
##########
@@ -75,19 +75,21 @@ public RangePartitionPruner(Map<Long, PartitionItem> rangeMap,
         Column keyColumn = partitionColumns.get(columnIdx);
         PartitionColumnFilter filter = partitionColumnFilters.get(keyColumn.getName());
         if (null == filter) {
-            minKey.pushColumn(LiteralExpr.createInfinity(Type.fromPrimitiveType(keyColumn.getDataType()), false),
-                    keyColumn.getDataType());
-            maxKey.pushColumn(LiteralExpr.createInfinity(Type.fromPrimitiveType(keyColumn.getDataType()), true),
-                    keyColumn.getDataType());
+            int pushMinCount = minKey.fillWithInfinity(partitionColumns, false);

Review comment:
       > If there is no condition in the first column, should we directly add the infinity range of the first column, right?
   
   Done. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org