You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2018/06/01 16:10:17 UTC

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 )

Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously
......................................................................


Patch Set 1:

Thanks for your contribution!

One nit about the commit message:

https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala

"Each [line of the commit message] should have 72 or fewer characters if possible. The first line should have an empty line after it, and the first line should begin with the ticket(s) addressed, followed by a colon and a space: 'IMPALA-1234: '."


-- 
To view, visit http://gerrit.cloudera.org:8080/10560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Gerrit-Change-Number: 10560
Gerrit-PatchSet: 1
Gerrit-Owner: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 16:10:17 +0000
Gerrit-HasComments: No