You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/08/11 15:50:51 UTC
[PR] feat: Add new trait for operator serde [datafusion-comet]
andygrove opened a new pull request, #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
For consistency with the expression serde, I would like to introduce a trait for operator serde.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Add `opSerdeMap`
- Add `CometOperatorSerde` trait
- Add `CometProjectExec` implementation
- Update `operator2Proto` to lookup serde handlers from the map
- Improve fallback reporting in the case where `COMET_EXEC_PROJECT_ENABLED` is `false`
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#issuecomment-3175504877
@peter-toth could you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270209928
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
Review Comment:
this probably can be simplified
```suggestion
opSerdeMap.get(op.getClass).foreach { handler =>
handler.enabledConfig.foreach { cfg =>
if (!cfg.get(op.conf)) {
withInfo(
op,
s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
s"Set ${cfg.key}=true to enable it."
)
return None
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270213687
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
Review Comment:
```suggestion
opSerdeMap.get(op.getClass).foreach { handler =>
handler.enabledConfig.foreach { cfg =>
if (!cfg.get(op.conf)) {
withInfo(
op,
s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
s"Set ${cfg.key}=true to enable it."
)
return None
}
}
}
```
This probably can be simplified, but I havent' tested the code, just the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270356501
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
Review Comment:
I pushed a small improvement based on your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270209928
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
Review Comment:
this probably can be simplified
```suggestion
opSerdeMap.get(op.getClass).foreach { handler =>
handler.enabledConfig.foreach { cfg =>
if (!cfg.get(op.conf)) {
withInfo(
op,
s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
s"Set ${cfg.key}=true to enable it."
)
return None
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270221568
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
+ handler.asInstanceOf[CometOperatorSerde[SparkPlan]].convert(op, builder, childOp: _*)
Review Comment:
if we know handler is only instanceOf `CometOperatorSerde[SparkPlan]` should we have the strong typed it in `opSerdeMap` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270194581
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2270392260
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2285,15 +2261,31 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case op =>
- // Emit warning if:
- // 1. it is not Spark shuffle operator, which is handled separately
- // 2. it is not a Comet operator
- if (!op.nodeName.contains("Comet") && !op.isInstanceOf[ShuffleExchangeExec]) {
- val msg = s"unsupported Spark operator: ${op.nodeName}"
- emitWarning(msg)
- withInfo(op, msg)
+ opSerdeMap.get(op.getClass) match {
+ case Some(handler) =>
+ handler.enabledConfig match {
+ case Some(enabledConfig) =>
+ if (!enabledConfig.get(op.conf)) {
+ withInfo(
+ op,
+ s"Native support for operator ${op.getClass.getSimpleName} is disabled. " +
+ s"Set ${enabledConfig.key}=true to enable it.")
+ return None
+ }
+ case _ =>
+ }
+ handler.asInstanceOf[CometOperatorSerde[SparkPlan]].convert(op, builder, childOp: _*)
Review Comment:
I experimented with this but could not find a way to remove the cast without adding additional complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#issuecomment-3175964981
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.42857%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 34.10%. Comparing base ([`f09f8af`](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b45650e`](https://app.codecov.io/gh/apache/datafusion-comet/commit/b45650e614b6b246e743025a1ce2695479fb3e3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 368 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../scala/org/apache/comet/serde/QueryPlanSerde.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fserde%2FQueryPlanSerde.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9zZXJkZS9RdWVyeVBsYW5TZXJkZS5zY2FsYQ==) | 38.46% | [6 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cala/org/apache/comet/serde/CometProjectExec.scala](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?src=pr&el=tree&filepath=spark%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fcomet%2Fserde%2FCometProjectExec.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3Bhcmsvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9jb21ldC9zZXJkZS9Db21ldFByb2plY3RFeGVjLnNjYWxh) | 88.88% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2115 +/- ##
=============================================
- Coverage 56.12% 34.10% -22.03%
+ Complexity 976 848 -128
=============================================
Files 119 142 +23
Lines 11743 13211 +1468
Branches 2251 2345 +94
=============================================
- Hits 6591 4505 -2086
- Misses 4012 7797 +3785
+ Partials 1140 909 -231
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/2115?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2267326127
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -62,6 +62,12 @@ import org.apache.comet.shims.CometExprShim
*/
object QueryPlanSerde extends Logging with CometExprShim {
+ /**
+ * Mapping of Spark operator class to Comet operator handler.
+ */
+ private val opSerdeMap: Map[Class[_], CometOperatorSerde[_]] = Map(
Review Comment:
Thanks. I have updated this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on code in PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#discussion_r2267311518
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -62,6 +62,12 @@ import org.apache.comet.shims.CometExprShim
*/
object QueryPlanSerde extends Logging with CometExprShim {
+ /**
+ * Mapping of Spark operator class to Comet operator handler.
+ */
+ private val opSerdeMap: Map[Class[_], CometOperatorSerde[_]] = Map(
Review Comment:
Maybe `Class[_ <: SparkPlan]` to accept only `SparkPlan`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Add new trait for operator serde [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #2115:
URL: https://github.com/apache/datafusion-comet/pull/2115#issuecomment-3180527166
Thanks for the reviews @peter-toth @comphead @mbutrovich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org