[GitHub] [incubator-apisix] moonming commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

[GitBox <gi...@apache.org>]

moonming commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.
URL: https://github.com/apache/incubator-apisix/pull/1139#discussion_r380655099
 
 

 ##########
 File path: lua/apisix/consumer.lua
 ##########
 @@ -35,6 +36,10 @@ local function plugin_consumer()
     end
 
     for _, consumer in ipairs(consumers.values) do
+        if type(consumer) ~= "table" then
 
 Review comment:
   ```
   if type(consumer) == "table" then
       for ...
   end
   ```
   is better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services