You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by jo...@apache.org on 2016/10/09 15:07:45 UTC
zeppelin git commit: [Zeppelin-907] Apply new mechanism to
AngularInterpreter
Repository: zeppelin
Updated Branches:
refs/heads/master 1f6ff6875 -> 702666480
[Zeppelin-907] Apply new mechanism to AngularInterpreter
### What is this PR for?
This PR applies the new interpreter registration mechanism to Angular interpreter.
### What type of PR is it?
Improvement
### Todos
* [x] Remove static property definition code lines in `AngularInterpreter.java` and create `interpreter-setting.json` under `angular/src/main/resources` directory
### What is the Jira issue?
[ZEPPELIN-907](https://issues.apache.org/jira/browse/ZEPPELIN-907)
### How should this be tested?
- apply this patch
- `rm -r interpreter/angular/` and `rm conf/interpreter.json`
- build source with maven
- `bin/zeppelin-daemon.sh start`
- Run with Angular
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Kai Jiang <ji...@gmail.com>
Closes #1496 from vectorijk/zeppelin-907 and squashes the following commits:
e6a263d [Kai Jiang] Apply new mechanism to AngularInterpreter
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/70266648
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/70266648
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/70266648
Branch: refs/heads/master
Commit: 702666480b91e30f9e39f3eb5f54465e6802e86c
Parents: 1f6ff68
Author: Kai Jiang <ji...@gmail.com>
Authored: Sat Oct 8 02:06:48 2016 -0700
Committer: Jongyoul Lee <jo...@apache.org>
Committed: Mon Oct 10 00:06:28 2016 +0900
----------------------------------------------------------------------
.../org/apache/zeppelin/angular/AngularInterpreter.java | 3 ---
angular/src/main/resources/interpreter-setting.json | 10 ++++++++++
2 files changed, 10 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/70266648/angular/src/main/java/org/apache/zeppelin/angular/AngularInterpreter.java
----------------------------------------------------------------------
diff --git a/angular/src/main/java/org/apache/zeppelin/angular/AngularInterpreter.java b/angular/src/main/java/org/apache/zeppelin/angular/AngularInterpreter.java
index 1b65f0f..f8ff350 100644
--- a/angular/src/main/java/org/apache/zeppelin/angular/AngularInterpreter.java
+++ b/angular/src/main/java/org/apache/zeppelin/angular/AngularInterpreter.java
@@ -34,9 +34,6 @@ import org.apache.zeppelin.scheduler.SchedulerFactory;
*
*/
public class AngularInterpreter extends Interpreter {
- static {
- Interpreter.register("angular", AngularInterpreter.class.getName());
- }
public AngularInterpreter(Properties property) {
super(property);
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/70266648/angular/src/main/resources/interpreter-setting.json
----------------------------------------------------------------------
diff --git a/angular/src/main/resources/interpreter-setting.json b/angular/src/main/resources/interpreter-setting.json
new file mode 100644
index 0000000..9e379de
--- /dev/null
+++ b/angular/src/main/resources/interpreter-setting.json
@@ -0,0 +1,10 @@
+[
+ {
+ "group": "angular",
+ "name": "angular",
+ "className": "org.apache.zeppelin.angular.AngularInterpreter",
+ "properties": {
+
+ }
+ }
+]