[GitHub] [pinot] jadami10 commented on a diff in pull request #10221: Change scripts to use npm ci and webpack --mode development by default

["jadami10 (via GitHub)" <gi...@apache.org>]

jadami10 commented on code in PR #10221:
URL: https://github.com/apache/pinot/pull/10221#discussion_r1155387697


##########
pinot-controller/pom.xml:
##########
@@ -33,7 +33,7 @@
   <url>https://pinot.apache.org/</url>
   <properties>
     <pinot.root>${basedir}/..</pinot.root>
-    <npm.script>build</npm.script>
+    <npm.script>build-ci</npm.script>

Review Comment:
   Can we undo this change. This has effectively made it so everyone building this project outside of that one Dockerfile is actually building dev. I randomly caught this on one of our clusters because we (and probably others) build from source ourselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org