You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "acelyc111 (via GitHub)" <gi...@apache.org> on 2024/05/29 08:24:25 UTC
[PR] feat(build): Support to specify THIRDPARTY_ROOT by setting the environment variable [incubator-pegasus]
acelyc111 opened a new pull request, #2035:
URL: https://github.com/apache/incubator-pegasus/pull/2035
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(build): Support to specify THIRDPARTY_ROOT by setting the environment variable [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #2035:
URL: https://github.com/apache/incubator-pegasus/pull/2035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(build): Support to specify THIRDPARTY_ROOT by setting the environment variable [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #2035:
URL: https://github.com/apache/incubator-pegasus/pull/2035#discussion_r1618645928
##########
scripts/compile_thrift.py:
##########
@@ -220,13 +220,13 @@ def add_hook(name, path, func, args):
if __name__ == "__main__":
root_dir = os.getcwd()
- thrift_exe = root_dir + "/thirdparty/output/bin/thrift"
+ thrift_exe = os.environ['THIRDPARTY_ROOT'] + "/output/bin/thrift"
print("thrift_exe = " + thrift_exe)
print("root_dir = " + root_dir)
if not os.path.isfile(thrift_exe):
print("Error: can't find compiler %s\nPlease build thrift in thirdparty/" % thrift_exe)
Review Comment:
`thirdparty/` should also be changed ?
##########
scripts/pack_server.sh:
##########
@@ -116,15 +116,15 @@ copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_replica_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_utils.so ${pack}/bin
if [ "$use_jemalloc" == "on" ]; then
- copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/bin
- copy_file ./thirdparty/output/lib/libprofiler.so.0 ${pack}/bin
+ copy_file ${THIRDPARTY_ROOT}/output/lib/libjemalloc.so.2 ${pack}/bin
Review Comment:
Before copy_file check if env `THIRDPARTY_ROOT` is an existing dir ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] feat(build): Support to specify THIRDPARTY_ROOT by setting the environment variable [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #2035:
URL: https://github.com/apache/incubator-pegasus/pull/2035#discussion_r1618802684
##########
scripts/pack_server.sh:
##########
@@ -116,15 +116,15 @@ copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_replica_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_utils.so ${pack}/bin
if [ "$use_jemalloc" == "on" ]; then
- copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/bin
- copy_file ./thirdparty/output/lib/libprofiler.so.0 ${pack}/bin
+ copy_file ${THIRDPARTY_ROOT}/output/lib/libjemalloc.so.2 ${pack}/bin
Review Comment:
scripts/pack_server.sh is typically called by ./run.sh, the `THIRDPARTY_ROOT` has been set. And `copy_file` will exit if the source file is not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org