You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/07 11:56:51 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
davids5 opened a new pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669
## Summary
Timeouts were occurring on STMF4 based platforms on differnt SD card based on formatting, and age. For additional information [See](https://github.com/PX4/PX4-Autopilot/issues/17442#issuecomment-834209116)
## Impact
The hard coded contestant would timeout at 100+ Ms. The spec is 250.
## Testing
PX4 fmu-v3 (stm32F4)
PX4 fmu-v5X (stm32F7)
PX4 fmu-v6X (stm32H7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino merged pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
antmerlino merged pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628378366
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
Review comment:
Reformatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628358830
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ UINT32_C(48000000)
+#define SDIO_DTIMER_DATATIMEOUT_MS 250
Review comment:
```suggestion
#define IP_CLCK_FREQ UINT32_C(48000000)
#define SDIO_DTIMER_DATATIMEOUT_MS 250
```
nit: suggestion for alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834629929
@gustavonihei - Thank you for being so thorough!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834649902
> > @gustavonihei - Thank you for being so thorough!
>
> I'll take that as a compliment!
Good! Because It was meant as one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628378450
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ UINT32_C(48000000)
+#define SDIO_DTIMER_DATATIMEOUT_MS 250
Review comment:
Reformatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628179929
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ 48000000ll
Review comment:
```suggestion
#define IP_CLCK_FREQ UINT32_C(48000000)
```
This macro from `inttypes.h` is not much widespread, but it is a more portable way for defining minimum-width integer constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628245765
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ 48000000ll
Review comment:
Done! I had to fix the CI fails and I can not disagree with your sound logic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834309100
Commiters Please review but wait for @antmerlino to cross test and approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628360983
##########
File path: arch/arm/src/stm32f7/stm32_sdmmc.c
##########
@@ -1223,9 +1237,25 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(struct stm32_dev_s *priv, uint32_t timeout,
uint32_t dlen, uint32_t dctrl)
{
- uint32_t regval = 0;
+ uint32_t clkdiv;
Review comment:
```suggestion
uint32_t clkdiv = 0;
```
nit: same as the previous one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628357626
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
Review comment:
```suggestion
```
This empty line may be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834800404
@jerpelea - This is critical for STM32 if CONFIG_MMCSD_MULTIBLOCK_DISABLE=y is not lit (using MULTIBLOCK) the driver will fail without this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628210148
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ 48000000ll
Review comment:
> Hmm, It is not intuitive or obvious.
I don't agree with not being intuitive. The `ll` suffix is implementation-dependent, so you need prior knowledge on this. Meanwhile, using `UINT32_C` these details are abstracted, the developer just needs to ensure that this integer constant is at least 32-bit wide.
By the way, `IP_CLCK_FREQ` will be attributed to a `uint32_t` variable, so adding the `ll` suffix you are prone to type conversion. The correct for the `armv7-m` architecture would be `ul`.
> Do you object to leaving it as is in this acrh specific file?
No objection at all. But I believe that using the macros from `inttypes.h` is less error-prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628200676
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
-#define SDIO_DTIMER_DATATIMEOUT (0x000fffff)
+#define IP_CLCK_FREQ 48000000ll
Review comment:
Hmm, It is not intuitive or obvious.
Do you object to leaving it as is in this acrh specific file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628379657
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -1016,9 +1021,24 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(uint32_t timeout, uint32_t dlen, uint32_t dctrl)
{
- uint32_t regval = 0;
+ uint32_t clkdiv;
Review comment:
Thanks. All Vars are initialized in the body, So I opted to remove the wasteful inits.
##########
File path: arch/arm/src/stm32f7/stm32_sdmmc.c
##########
@@ -1223,9 +1237,25 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(struct stm32_dev_s *priv, uint32_t timeout,
uint32_t dlen, uint32_t dctrl)
{
- uint32_t regval = 0;
+ uint32_t clkdiv;
Review comment:
"
##########
File path: arch/arm/src/stm32h7/stm32_sdmmc.c
##########
@@ -1080,6 +1094,9 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(struct stm32_dev_s *priv, uint32_t timeout,
uint32_t dlen, bool receive)
{
+ uint32_t clkdiv;
Review comment:
"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628361646
##########
File path: arch/arm/src/stm32h7/stm32_sdmmc.c
##########
@@ -1080,6 +1094,9 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(struct stm32_dev_s *priv, uint32_t timeout,
uint32_t dlen, bool receive)
{
+ uint32_t clkdiv;
Review comment:
```suggestion
uint32_t clkdiv = 0;;
```
##########
File path: arch/arm/src/stm32h7/stm32_sdmmc.c
##########
@@ -1080,6 +1094,9 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(struct stm32_dev_s *priv, uint32_t timeout,
uint32_t dlen, bool receive)
{
+ uint32_t clkdiv;
Review comment:
```suggestion
uint32_t clkdiv = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628202549
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -1049,10 +1069,10 @@ static void stm32_datadisable(void)
{
uint32_t regval;
- /* Disable the data path */
+ /* Disable the data path */
- putreg32(SDIO_DTIMER_DATATIMEOUT, STM32_SDIO_DTIMER); /* Reset DTIMER */
- putreg32(0, STM32_SDIO_DLEN); /* Reset DLEN */
+ putreg32(~0, STM32_SDIO_DTIMER); /* Reset DTIMER */
Review comment:
I have recently grown found of ~0. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628182063
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -1049,10 +1069,10 @@ static void stm32_datadisable(void)
{
uint32_t regval;
- /* Disable the data path */
+ /* Disable the data path */
- putreg32(SDIO_DTIMER_DATATIMEOUT, STM32_SDIO_DTIMER); /* Reset DTIMER */
- putreg32(0, STM32_SDIO_DLEN); /* Reset DLEN */
+ putreg32(~0, STM32_SDIO_DTIMER); /* Reset DTIMER */
Review comment:
```suggestion
putreg32(UINT32_MAX, STM32_SDIO_DTIMER); /* Reset DTIMER */
```
nit: just a suggestion hehe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628245989
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -1049,10 +1069,10 @@ static void stm32_datadisable(void)
{
uint32_t regval;
- /* Disable the data path */
+ /* Disable the data path */
- putreg32(SDIO_DTIMER_DATATIMEOUT, STM32_SDIO_DTIMER); /* Reset DTIMER */
- putreg32(0, STM32_SDIO_DLEN); /* Reset DLEN */
+ putreg32(~0, STM32_SDIO_DTIMER); /* Reset DTIMER */
Review comment:
"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628357950
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
Review comment:
```suggestion
/* DTIMER setting
*
* Assuming Max timeout in bypass 48 Mhz
*/
```
nit: This empty line may be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628359732
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -1016,9 +1021,24 @@ static uint8_t stm32_log2(uint16_t value)
static void stm32_dataconfig(uint32_t timeout, uint32_t dlen, uint32_t dctrl)
{
- uint32_t regval = 0;
+ uint32_t clkdiv;
Review comment:
```suggestion
uint32_t clkdiv = 0;
```
nit: since regval is being initialized, `clkdiv` could also be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834631627
> @gustavonihei - Thank you for being so thorough!
I'll take that as a compliment! :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628357950
##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
#define SDIO_CMDTIMEOUT (100000)
#define SDIO_LONGTIMEOUT (0x7fffffff)
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
Review comment:
```suggestion
/* DTIMER setting
*
* Assuming Max timeout in bypass 48 Mhz
*/
```
This empty line may be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#issuecomment-834613295
LGTM.
I just focused on code quality aspects. Since I don't know much about these peripherals, I'll let the approval for the other reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org