[GitHub] [camel-k] christophd commented on a diff in pull request #4120: fix(knative): Integration in error state when knative SinkBinding mode=inclusion

["christophd (via GitHub)" <gi...@apache.org>]

christophd commented on code in PR #4120:
URL: https://github.com/apache/camel-k/pull/4120#discussion_r1133575030


##########
e2e/yaks/common/knative-sinkbinding-http/sinkbinding.feature:
##########
@@ -0,0 +1,9 @@
+Feature: Camel K can run source HTTP endpoint in sinkbinding mode
+
+  Background:
+    Given Kubernetes resource polling configuration
+      | maxAttempts          | 1   |
+      | delayBetweenAttempts | 500 |
+
+  Scenario: Integration knative-service starts with no errors
+    Given wait for condition=Ready on Kubernetes custom resource integration/rest2channel in integration.camel.apache.org/v1

Review Comment:
   Why not use the Camel K step `Given Camel K integration rest2channel is running`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org