You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2020/01/09 15:00:19 UTC

[isis] 02/05: ISIS-2250: fixes logic bug resulting in infinite loop when introspecting.

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git

commit 8ac71eadbceca9aacf5979f86daa4c5ba2acf4b9
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Thu Jan 9 11:25:09 2020 +0000

    ISIS-2250: fixes logic bug resulting in infinite loop when introspecting.
---
 .../isis/metamodel/specloader/SpecificationLoaderDefault.java  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java b/core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
index 6a743d9..547634e 100644
--- a/core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
+++ b/core/metamodel/src/main/java/org/apache/isis/metamodel/specloader/SpecificationLoaderDefault.java
@@ -345,11 +345,11 @@ public class SpecificationLoaderDefault implements SpecificationLoader {
 
         if (this.validationResult.isMemoized()) {
             this.validationResult.clear();
-        }
-        final ValidationFailures validationFailures = this.getValidationResult();
+            final ValidationFailures validationFailures = this.getValidationResult();
 
-        if(validationFailures.hasFailures()) {
-            throw _Exceptions.illegalState(String.join("\n", validationFailures.getMessages("[%d] %s")));
+            if(validationFailures.hasFailures()) {
+                throw _Exceptions.illegalState(String.join("\n", validationFailures.getMessages("[%d] %s")));
+            }
         }
     }
 
@@ -447,7 +447,7 @@ public class SpecificationLoaderDefault implements SpecificationLoader {
         
         specs.parallelStream()
         .forEach(spec -> spec.introspectUpTo(upTo)); // TODO swallows exceptions that happen inside (makes debugging hard)
-        
+
     }
 
     private void invalidateCache(final Class<?> cls) {