You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/20 02:32:26 UTC
[GitHub] [flink] yanghua opened a new pull request #10906: [FLINK-15601]
Remove useless constant field NUM_STOP_CALL_TRIES in Execution
yanghua opened a new pull request #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906
## What is the purpose of the change
*This pull request removes useless constant field NUM_STOP_CALL_TRIES in Execution*
## Brief change log
- *Remove useless constant field NUM_STOP_CALL_TRIES in Execution*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #10906: [FLINK-15601] Remove
useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10906: [FLINK-15601]
Remove useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906#issuecomment-576090154
<!--
Meta data
Hash:e0212f18a3e85a756898bc51e63663275491e59e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145153490 TriggerType:PUSH TriggerID:e0212f18a3e85a756898bc51e63663275491e59e
Hash:e0212f18a3e85a756898bc51e63663275491e59e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4489 TriggerType:PUSH TriggerID:e0212f18a3e85a756898bc51e63663275491e59e
-->
## CI report:
* e0212f18a3e85a756898bc51e63663275491e59e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145153490) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10906: [FLINK-15601]
Remove useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906#issuecomment-576090154
<!--
Meta data
Hash:e0212f18a3e85a756898bc51e63663275491e59e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145153490 TriggerType:PUSH TriggerID:e0212f18a3e85a756898bc51e63663275491e59e
Hash:e0212f18a3e85a756898bc51e63663275491e59e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4489 TriggerType:PUSH TriggerID:e0212f18a3e85a756898bc51e63663275491e59e
-->
## CI report:
* e0212f18a3e85a756898bc51e63663275491e59e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145153490) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] yanghua commented on issue #10906: [FLINK-15601] Remove
useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906#issuecomment-576560669
cc @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10906: [FLINK-15601] Remove
useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906#issuecomment-576082686
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e0212f18a3e85a756898bc51e63663275491e59e (Mon Jan 20 02:34:59 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10906: [FLINK-15601] Remove
useless constant field NUM_STOP_CALL_TRIES in Execution
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10906: [FLINK-15601] Remove useless constant field NUM_STOP_CALL_TRIES in Execution
URL: https://github.com/apache/flink/pull/10906#issuecomment-576090154
<!--
Meta data
Hash:e0212f18a3e85a756898bc51e63663275491e59e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e0212f18a3e85a756898bc51e63663275491e59e
-->
## CI report:
* e0212f18a3e85a756898bc51e63663275491e59e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services