You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/11 04:52:03 UTC
[GitHub] [hudi] TJX2014 opened a new pull request, #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
TJX2014 opened a new pull request, #6917:
URL: https://github.com/apache/hudi/pull/6917
### Change Logs
Flink writer not consider aborted instant to write
### Impact
Bug fix.
**Risk level: none | low | medium | high**
none
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 closed pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
URL: https://github.com/apache/hudi/pull/6917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] TJX2014 commented on pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on PR #6917:
URL: https://github.com/apache/hudi/pull/6917#issuecomment-1274092489
@danny0405 Please help review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6917:
URL: https://github.com/apache/hudi/pull/6917#issuecomment-1274095353
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe0f4401f446db88ff07ea6d95540bffed97c693 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6917:
URL: https://github.com/apache/hudi/pull/6917#issuecomment-1274098391
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12122",
"triggerID" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe0f4401f446db88ff07ea6d95540bffed97c693 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12122)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6917:
URL: https://github.com/apache/hudi/pull/6917#discussion_r991882732
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -175,8 +175,8 @@ public String lastPendingInstant() {
load();
if (this.messages.size() > 0) {
CkpMessage ckpMsg = this.messages.get(this.messages.size() - 1);
- // consider 'aborted' as pending too to reuse the instant
- if (!ckpMsg.isComplete()) {
+ // should not consider 'aborted', which will lead writer instant not consistent with coordinator
+ if (ckpMsg.isInflight()) {
return ckpMsg.getInstant();
Review Comment:
We never abort a checkpoint in master code now, can you double check this logic again ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] TJX2014 commented on a diff in pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
TJX2014 commented on code in PR #6917:
URL: https://github.com/apache/hudi/pull/6917#discussion_r991912456
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -175,8 +175,8 @@ public String lastPendingInstant() {
load();
if (this.messages.size() > 0) {
CkpMessage ckpMsg = this.messages.get(this.messages.size() - 1);
- // consider 'aborted' as pending too to reuse the instant
- if (!ckpMsg.isComplete()) {
+ // should not consider 'aborted', which will lead writer instant not consistent with coordinator
+ if (ckpMsg.isInflight()) {
return ckpMsg.getInstant();
Review Comment:
Thanks, no abort in coordinator, I will check other situation of abort instant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6917:
URL: https://github.com/apache/hudi/pull/6917#issuecomment-1274453643
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12122",
"triggerID" : "fe0f4401f446db88ff07ea6d95540bffed97c693",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fe0f4401f446db88ff07ea6d95540bffed97c693 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12122)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6917: [HUDI-5005] Flink stream write reuse abort instant will lead to coordinator delete file not right.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #6917:
URL: https://github.com/apache/hudi/pull/6917#issuecomment-1473275024
Close because it is invalid since #7620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org