You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/12/02 13:57:56 UTC
[GitHub] [opennlp-site] rzo1 opened a new pull request, #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
rzo1 opened a new pull request, #73:
URL: https://github.com/apache/opennlp-site/pull/73
as the title says.
https://matomo.privacy.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow commented on pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335324888
Just waiting for Travis (:man_shrugging: even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] jzonthemtn commented on pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
jzonthemtn commented on PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1336181918
@rzo1 @kinow I could be wrong, but I don't think Travis CI is doing anything here and we can just delete the `.travis.yml` file. Pushing a commit triggers build bot and it does the deploy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow commented on a diff in pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038178860
##########
src/main/jbake/templates/footer.ftl:
##########
@@ -40,5 +40,24 @@
link.parents('li,ul').addClass('active');
</script>
+
+ <!-- Matomo -->
+ <script>
+ var _paq = window._paq = window._paq || [];
+ /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+ /* We explicitly disable cookie tracking to avoid privacy issues */
+ _paq.push(['disableCookies']);
+ /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
Review Comment:
Thanks! I think this is the first ASF I participate that I know Matomo is used. Looking forward to learning how it works and maybe suggest to other projects I contribute to to try that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow commented on pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335392946
True, LGTM. I think I saw an email from... INFRA? Telling projects to migrate away from Travis. Merging and updating JIRA. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] rzo1 commented on a diff in pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038180787
##########
src/main/jbake/templates/footer.ftl:
##########
@@ -40,5 +40,24 @@
link.parents('li,ul').addClass('active');
</script>
+
+ <!-- Matomo -->
+ <script>
+ var _paq = window._paq = window._paq || [];
+ /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+ /* We explicitly disable cookie tracking to avoid privacy issues */
+ _paq.push(['disableCookies']);
+ /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
Review Comment:
Maven is using it for quite a while now and the list is growing but it isn't promoted across the TLPs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow commented on pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1336189151
> @rzo1 @kinow I could be wrong, but I don't think Travis CI is doing anything here and we can just delete the `.travis.yml` file. Pushing a commit triggers build bot and it does the deploy.
Sounds good to me. Either delete it or replace by GH Actions to just build JBake/Maven. Either way would be better than having Travis as it's really slow these days :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow commented on a diff in pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038173686
##########
src/main/jbake/templates/footer.ftl:
##########
@@ -40,5 +40,24 @@
link.parents('li,ul').addClass('active');
</script>
+
+ <!-- Matomo -->
+ <script>
+ var _paq = window._paq = window._paq || [];
+ /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+ /* We explicitly disable cookie tracking to avoid privacy issues */
+ _paq.push(['disableCookies']);
+ /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
+ _paq.push(['trackPageView']);
+ _paq.push(['enableLinkTracking']);
+ (function() {
+ var u="//analytics.apache.org/";
+ _paq.push(['setTrackerUrl', u+'matomo.php']);
+ _paq.push(['setSiteId', '33']);
Review Comment:
https://analytics.apache.org/index.php?module=CoreHome&action=index&date=yesterday&period=day&idSite=33
:+1: thanks!
##########
src/main/jbake/templates/footer.ftl:
##########
@@ -40,5 +40,24 @@
link.parents('li,ul').addClass('active');
</script>
+
+ <!-- Matomo -->
+ <script>
+ var _paq = window._paq = window._paq || [];
+ /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+ /* We explicitly disable cookie tracking to avoid privacy issues */
+ _paq.push(['disableCookies']);
+ /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
Review Comment:
I think the comment above was copy-pasted, but it's actually opennlp.apache.org (there's no opennlp under nightlies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] rzo1 commented on a diff in pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#discussion_r1038175207
##########
src/main/jbake/templates/footer.ftl:
##########
@@ -40,5 +40,24 @@
link.parents('li,ul').addClass('active');
</script>
+
+ <!-- Matomo -->
+ <script>
+ var _paq = window._paq = window._paq || [];
+ /* tracker methods like "setCustomDimension" should be called before "trackPageView" */
+ /* We explicitly disable cookie tracking to avoid privacy issues */
+ _paq.push(['disableCookies']);
+ /* Measure a visit to flink.apache.org and nightlies.apache.org/flink as the same visit */
Review Comment:
Yes, this is true. It is copy pasted from the Privacy Slack, there Martjin Visser posted the snippet for us. I will change the flink comment ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] rzo1 commented on pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #73:
URL: https://github.com/apache/opennlp-site/pull/73#issuecomment-1335340181
> Just waiting for Travis (man_shrugging even though it shouldn't matter for this PR) before merging (others can merge it now if they prefer).
Guess we need to migrate away from Travis CI any time soon. I read, that ASF discontinous to use it, so we obviously need to change that in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [opennlp-site] kinow merged pull request #73: OPENNLP-1399 - Integrate ASF Matomo into OpenNLP website
Posted by GitBox <gi...@apache.org>.
kinow merged PR #73:
URL: https://github.com/apache/opennlp-site/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org