[GitHub] [zookeeper] ztzg commented on a change in pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…

[GitBox <gi...@apache.org>]

ztzg commented on a change in pull request #1115: ZOOKEEPER-3574: Close quorum socket asynchronously to avoid server sh…
URL: https://github.com/apache/zookeeper/pull/1115#discussion_r400092053
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
 ##########
 @@ -116,10 +120,14 @@ public Socket getSocket() {
 
     public static final String LEARNER_ASYNC_SENDING = "learner.asyncSending";
     private static boolean asyncSending = Boolean.getBoolean(LEARNER_ASYNC_SENDING);
+    public static final String LEARNER_CLOSE_SOCKET_ASYNC = "learner.closeSocketAsync";
+    public static final boolean closeSocketAsync = Boolean.getBoolean(LEARNER_CLOSE_SOCKET_ASYNC);
 
 Review comment:
   Not trying to block this PR, and things can be improved later, but:
   
   I see that such properties, including `learner.asyncSending` above it, are not documented.  Is there a specific policy regarding which properties are to be mentioned in `zookeeperAdmin.md`?  I am wondering how one can learn about all these knobs, and their raison d'être?  (I know the corresponding ticket ID can be found via Git, but that incurs some overhead.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services