[GitHub] [incubator-doris] morningman commented on a change in pull request #4245: Do not wrap NULL type expr to IF(TupleIsNull(tids), NULL, expr)

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4245:
URL: https://github.com/apache/incubator-doris/pull/4245#discussion_r466488297



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -61,6 +61,7 @@ public CastExpr(Type targetType, Expr e) {
             try {
                 analyze();
             } catch (AnalysisException ex) {
+                LOG.error("Implicit casts fail", ex);

Review comment:
       please use `warn` level.
   `error` always means some fatal error. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org