You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "dingshuangxi888 (via GitHub)" <gi...@apache.org> on 2026/09/08 12:34:43 UTC

[PR] fix(auth): tolerate blank subscription topics in heartbeats [rocketmq]

dingshuangxi888 opened a new pull request, #11082:
URL: https://github.com/apache/rocketmq/pull/11082

   ### Which Issue(s) This PR Fixes
   
   Follow-up to #11009; no separate issue.
   
   ### Brief Description
   
   A Remoting consumer heartbeat containing a blank subscription topic is rejected with `topic is null`, even when it also contains valid subscriptions. Skip null, empty, and whitespace-only topic names when building heartbeat authorization contexts so that the remaining subscriptions can be authorized.
   
   Consumer-group and valid-topic SUB authorization contexts are preserved, including group authorization when all subscription topics are blank. Missing heartbeat bodies, null subscription entries, and invalid consumer-group names remain rejected.
   
   ### How Did You Test This Change?
   
   Added regression coverage for mixed valid/retry/blank topics, all-blank topic subscriptions retaining group authorization, and null subscription entry rejection.
   
   Ran on JDK 11:
   
   ```sh
   mvn -B -pl auth -am \
     -Dtest=DefaultAuthorizationContextBuilderTest,AuthorizationEvaluatorTest \
     -Dsurefire.failIfNoSpecifiedTests=false test
   ```
   
   36 tests: 35 passed and 1 existing platform-specific test skipped. Checkstyle and SpotBugs passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(auth): tolerate blank subscription topics in heartbeats [rocketmq]

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #11082:
URL: https://github.com/apache/rocketmq/pull/11082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(auth): tolerate blank subscription topics in heartbeats [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11082:
URL: https://github.com/apache/rocketmq/pull/11082#issuecomment-5586276457

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11082?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.86%. Comparing base ([`66362b9`](https://app.codecov.io/gh/apache/rocketmq/commit/66362b9c9f013f3ee7e510f5dbfb792c2053d3bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f3e7a38`](https://app.codecov.io/gh/apache/rocketmq/commit/f3e7a38e0fce1ec881fc0a63155662b0af8e2431?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on develop.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #11082      +/-   ##
   =============================================
   - Coverage      48.88%   48.86%   -0.02%     
   - Complexity     13801    13820      +19     
   =============================================
     Files           1381     1382       +1     
     Lines         101595   101599       +4     
     Branches       13215    13213       -2     
   =============================================
   - Hits           49661    49648      -13     
   + Misses         45910    45903       -7     
   - Partials        6024     6048      +24     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11082?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org