You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/08 14:12:17 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12353: fix: CSS injection order (#12265)
michael-s-molina opened a new pull request #12353:
URL: https://github.com/apache/superset/pull/12353
### SUMMARY
`CSS` templates were being overridden by other styles loaded by the application. This fix ensures that `CSS` templates are always the last child of `<head>`.
### AFTER FIX (before can be seen in #12265)
### TEST PLAN
1. Go to 'Any dashboard'
2. Click on 'Edit dashboard > Edit CSS'
3. Save CSS template
4. Refresh browser
5. Should keep CSS template
Closes #12265
@junlincc
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `3.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 63.66% -3.40%
==========================================
Files 1001 485 -516
Lines 49380 29873 -19507
Branches 5033 0 -5033
==========================================
- Hits 33112 19018 -14094
+ Misses 16140 10855 -5285
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.66% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.36% <0.00%> (-0.15%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 63.57% -3.49%
==========================================
Files 1001 485 -516
Lines 49380 29873 -19507
Branches 5033 0 -5033
==========================================
- Hits 33112 18991 -14121
+ Misses 16140 10882 -5258
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.57% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `3.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 63.62% -3.43%
==========================================
Files 1001 485 -516
Lines 49380 29873 -19507
Branches 5033 0 -5033
==========================================
- Hits 33112 19008 -14104
+ Misses 16140 10865 -5275
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.62% <ø> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `2.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 64.20% -2.85%
==========================================
Files 1001 485 -516
Lines 49380 29888 -19492
Branches 5033 0 -5033
==========================================
- Hits 33112 19191 -13921
+ Misses 16140 10697 -5443
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.20% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
| [...controls/DateFilterControl/frame/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9DYWxlbmRhckZyYW1lLnRzeA==) | | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [...frontend/src/profile/components/CreatedContent.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9DcmVhdGVkQ29udGVudC50c3g=) | | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3hDaGFydFBsdWdpbi5qcw==) | | |
| ... and [510 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `2.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 64.21% -2.84%
==========================================
Files 1001 485 -516
Lines 49380 29888 -19492
Branches 5033 0 -5033
==========================================
- Hits 33112 19194 -13918
+ Misses 16140 10694 -5446
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.21% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
| [...ore/components/controls/DateFilterControl/utils.ts](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy50cw==) | | |
| [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | | |
| [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | | |
| [...end/src/SqlLab/components/RunQueryActionButton.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLnRzeA==) | | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc merged pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #12353:
URL: https://github.com/apache/superset/pull/12353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `3.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 63.57% -3.49%
==========================================
Files 1001 485 -516
Lines 49380 29873 -19507
Branches 5033 0 -5033
==========================================
- Hits 33112 18991 -14121
+ Misses 16140 10882 -5258
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.57% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `82.45% <0.00%> (-3.51%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `2.84%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 64.20% -2.85%
==========================================
Files 1001 485 -516
Lines 49380 29888 -19492
Branches 5033 0 -5033
==========================================
- Hits 33112 19191 -13921
+ Misses 16140 10697 -5443
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.20% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.68% <0.00%> (-0.65%)` | :arrow_down: |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/components/RefreshChartOverlay.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaENoYXJ0T3ZlcmxheS50c3g=) | | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
| [.../dashboard/util/charts/getEffectiveExtraFilters.ts](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRFZmZlY3RpdmVFeHRyYUZpbHRlcnMudHM=) | | |
| [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxTZWN0aW9uLmpzeA==) | | |
| [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkTG9hZGluZy5qcw==) | | |
| ... and [510 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc merged pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #12353:
URL: https://github.com/apache/superset/pull/12353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `2.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 64.06% -3.00%
==========================================
Files 1001 485 -516
Lines 49380 29888 -19492
Branches 5033 0 -5033
==========================================
- Hits 33112 19147 -13965
+ Misses 16140 10741 -5399
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.06% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | | |
| ... and [515 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `4.23%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 62.81% -4.24%
==========================================
Files 1001 1014 +13
Lines 49380 49496 +116
Branches 5033 5070 +37
==========================================
- Hits 33112 31092 -2020
- Misses 16140 18195 +2055
- Partials 128 209 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.67% <100.00%> (-0.32%)` | :arrow_down: |
| python | `64.21% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/injectCustomCss.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2luamVjdEN1c3RvbUNzcy5qcw==) | `91.66% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12353: fix: CSS injection order (#12265)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12353:
URL: https://github.com/apache/superset/pull/12353#issuecomment-756900680
# [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=h1) Report
> Merging [#12353](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=desc) (852205a) into [master](https://codecov.io/gh/apache/superset/commit/d760e885d78e51a445caf3161a37c70a65e5e4c2?el=desc) (d760e88) will **decrease** coverage by `3.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12353 +/- ##
==========================================
- Coverage 67.05% 63.65% -3.41%
==========================================
Files 1001 485 -516
Lines 49380 29888 -19492
Branches 5033 0 -5033
==========================================
- Hits 33112 19025 -14087
+ Misses 16140 10863 -5277
+ Partials 128 0 -128
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.65% <ø> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-12.78%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `89.13% <0.00%> (-2.98%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | `100.00% <0.00%> (ø)` | |
| ... and [517 more](https://codecov.io/gh/apache/superset/pull/12353/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=footer). Last update [d760e88...852205a](https://codecov.io/gh/apache/superset/pull/12353?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org