You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org> on 2010/05/17 15:47:43 UTC

[jira] Created: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Clarify/identify where ACL permission should be applied in the broker 
----------------------------------------------------------------------

                 Key: QPID-2606
                 URL: https://issues.apache.org/jira/browse/QPID-2606
             Project: Qpid
          Issue Type: Sub-task
            Reporter: Andrew Kennedy




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871162#action_12871162 ] 

Robbie Gemmell commented on QPID-2606:
--------------------------------------

Ive started taking a look at this, but I notice in the patch that a couple of the files are entirely replaced for apparently small changea - the line endings on the files are not set to native in the repo. Ive set the native line endings property on the files, could you generate the patch again to pick up the changes.

There is alsothe odd //TODO in there alongside new code, seems like they should have been completed by now: if they havent then id recommend doing so, or if they have been then remove the comments :)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Forgot one file that was moved...

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

updated with METHOD access checks as well

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch

Changed test assertions to reflect updates to exception toString method

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch, 0002-QPID-2606-Added-AMQSecurityException.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Access-Control-Modifications.patch

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch, 0003-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0002-QPID-2606-Added-AMQSecurityException.patch

Extra file added to wrong patch initially

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0002-QPID-2606-Added-AMQSecurityException.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Access-Control-Modifications.patch

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

edited

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0002-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Use plugin manager and interfaces from QPID-2513 and QPID-2581 configuration plugin changes to implement updated ACL handling. These patches are required to make QPID-2542, QPID-2573 and QPID-2569 work.

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0002-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0005-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

qpid/java/broker/etc/config.xml
qpid/java/broker/src/main/java/org/apache/qpid/qmf/QMFService.java
qpid/java/broker/src/main/java/org/apache/qpid/server/AMQBrokerManagerMBean.java
qpid/java/broker/src/main/java/org/apache/qpid/server/AMQChannel.java
qpid/java/broker/src/main/java/org/apache/qpid/server/Main.java
qpid/java/broker/src/main/java/org/apache/qpid/server/binding/BindingFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/QueueConfiguration.java
qpid/java/broker/src/main/java/org/apache/qpid/server/configuration/ServerConfiguration.java
qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/AbstractExchangeMBean.java
qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/DefaultExchangeFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/DefaultExchangeRegistry.java
qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/Exchange.java
qpid/java/broker/src/main/java/org/apache/qpid/server/exchange/ExchangeFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/BasicConsumeMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/BasicGetMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/BasicPublishMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ChannelOpenHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ConnectionOpenMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ConnectionSecureOkMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ConnectionStartOkMethodHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ExchangeDeclareHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/ExchangeDeleteHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/QueueBindHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/QueueDeclareHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/QueueDeleteHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/QueuePurgeHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/handler/QueueUnbindHandler.java
qpid/java/broker/src/main/java/org/apache/qpid/server/management/MBeanInvocationHandlerImpl.java
qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/Plugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueue.java
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/AMQQueueMBean.java
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/SimpleAMQQueue.java
qpid/java/broker/src/main/java/org/apache/qpid/server/registry/ApplicationRegistry.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/AbstractPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/AbstractProxyPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/Result.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/SecurityManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/SecurityPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/SecurityPluginActivator.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/SecurityPluginFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/ACLManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/ACLPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/ACLPluginFactory.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/AccessResult.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/AccessRights.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/Accessable.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/ObjectProperties.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/ObjectType.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/Operation.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/Permission.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/PrincipalPermissions.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/VirtualHostAccess.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/management/AMQUserManagementMBean.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/AbstractACLPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/AllowAll.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/BasicACLPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/BasicPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/DenyAll.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/LegacyAccess.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/LegacyAccessPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/access/plugins/network/FirewallPlugin.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/AuthenticationResult.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/database/ConfigurationFilePrincipalDatabaseManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/AuthenticationManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/manager/PrincipalDatabaseAuthenticationManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/security/auth/rmi/RMIPasswordAuthenticator.java
qpid/java/broker/src/main/java/org/apache/qpid/server/state/AMQStateManager.java
qpid/java/broker/src/main/java/org/apache/qpid/server/subscription/SubscriptionFactoryImpl.java
qpid/java/broker/src/main/java/org/apache/qpid/server/transport/ServerConnectionDelegate.java
qpid/java/broker/src/main/java/org/apache/qpid/server/transport/ServerSession.java
qpid/java/broker/src/main/java/org/apache/qpid/server/transport/ServerSessionDelegate.java
qpid/java/broker/src/main/java/org/apache/qpid/server/virtualhost/VirtualHostImpl.java
qpid/java/broker/src/test/java/org/apache/qpid/server/plugins/PluginTest.java
qpid/java/broker/src/test/java/org/apache/qpid/server/queue/AMQQueueFactoryTest.java
qpid/java/broker/src/test/java/org/apache/qpid/server/queue/SimpleAMQQueueTest.java
qpid/java/broker/src/test/java/org/apache/qpid/server/security/access/ACLManagerTest.java
qpid/java/broker/src/test/java/org/apache/qpid/server/security/access/ExchangeDenier.java
qpid/java/broker/src/test/java/org/apache/qpid/server/security/access/PrincipalPermissionsTest.java
qpid/java/broker/src/test/java/org/apache/qpid/server/security/access/QueueDenier.java
qpid/java/broker/src/test/java/org/apache/qpid/server/security/access/plugins/network/FirewallPluginTest.java
qpid/java/build.deps
qpid/java/management/common/src/main/java/org/apache/qpid/management/common/mbeans/ManagedBroker.java
qpid/java/systests/etc/config-systests-aclv2-settings.xml
qpid/java/systests/etc/config-systests-aclv2.xml
qpid/java/systests/etc/global-default.txt
qpid/java/systests/etc/global-externaladminacl-changeloggerleveldenied.txt
qpid/java/systests/etc/global-externaladminacl-getallloggerlevelsdenied.txt
qpid/java/systests/etc/test-default.txt
qpid/java/systests/etc/test-externalacljmx-deleteexchangefailure.txt
qpid/java/systests/etc/test-externalacljmx.txt
qpid/java/systests/etc/test2-default.txt
qpid/java/systests/etc/virtualhosts-systests-acl-settings.xml
qpid/java/systests/etc/virtualhosts-systests-aclv2-settings.xml
qpid/java/systests/etc/virtualhosts-systests-aclv2.xml
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/AbstractACLTestCase.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/ExhaustiveACLTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/ExternalACLFileTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/ExternalACLJMXTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/ExternalACLTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/ExternalAdminACLTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/acl/SimpleACLTest.java
qpid/java/systests/src/main/java/org/apache/qpid/server/security/firewall/FirewallConfigTest.java
qpid/java/systests/src/main/java/org/apache/qpid/test/unit/topic/TopicSessionTest.java
qpid/java/systests/src/main/java/org/apache/qpid/test/utils/JMXTestUtils.java
qpid/java/systests/src/main/java/org/apache/qpid/test/utils/QpidTestCase.java


> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0002-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0005-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0004-QPID-2606-AMQSecurityException.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0019-QPID-2606-Added-AMQSecurityException.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0003-QPID-2606-Access-Control-Modifications.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-2606:
------------------------------------

    Assignee: Robbie Gemmell

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Made changes suggested and rolled up three patches into one.

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0003-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0003-QPID-2606-Access-Control-Modifications.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0002-QPID-2606-Added-AMQSecurityException.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870611#action_12870611 ] 

Andrew Kennedy commented on QPID-2606:
--------------------------------------

These should be applied in this order: 0002,  0004, then 0001...

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch, 0002-QPID-2606-Added-AMQSecurityException.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack resolved QPID-2606.
------------------------------------

    Resolution: Fixed

Detailed review completed by Robbie Gemmell prior to patch commit, Andrew fixed issues raised.

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Changed due to svn rebase

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0003-QPID-2606-Access-Control-Modifications.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch, 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0020-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0005-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Better patch, same caveats as previous attachment apply.

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0005-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment:     (was: 0003-QPID-2606-Access-Control-Modifications.patch)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0004-QPID-2606-AMQSecurityException.patch

Added patch for new AMQSecurityException file

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0004-QPID-2606-AMQSecurityException.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

(missed a file...)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-2606:
-----------------------------------

    Status: Ready To Review  (was: In Progress)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch

Improved handling of enqueue events (publishing)

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0010-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Access-Control-Modifications.patch

added fix for MessageDisappearWithIOExceptionTest failing

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Access-Control-Modifications.patch

Updated patch with review changes

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Commented: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873697#action_12873697 ] 

Robbie Gemmell commented on QPID-2606:
--------------------------------------

Patch applied

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0003-QPID-2606-Access-Control-Modifications.patch

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>            Assignee: Robbie Gemmell
>         Attachments: 0003-QPID-2606-Access-Control-Modifications.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2606) Clarify/identify where ACL permission should be applied in the broker

Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2606:
---------------------------------

    Attachment: 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch
                0019-QPID-2606-Added-AMQSecurityException.patch

> Clarify/identify where ACL permission should be applied in the broker 
> ----------------------------------------------------------------------
>
>                 Key: QPID-2606
>                 URL: https://issues.apache.org/jira/browse/QPID-2606
>             Project: Qpid
>          Issue Type: Sub-task
>            Reporter: Andrew Kennedy
>         Attachments: 0001-QPID-2606-Update-test-to-reflect-changes-to-excepti.patch, 0004-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0013-QPID-2606-Identify-where-ACL-permission-should-be-a.patch, 0019-QPID-2606-Added-AMQSecurityException.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org